Hmm. Having some issues with `./pants publish` and...
# generaln
narrow-vegetable-37489
11/30/2021, 2:12 PMHmm. Having some issues with
./pants publishDOCKER_HOST./pants packageDOCKER_HOST./pants publishnarrow-vegetable-37489
11/30/2021, 2:12 PM Copy code
$ echo $DOCKER_HOST
<tcp://dockerdaemon:2375/>
$ ./pants publish ::
04:59:07.04 [INFO] Starting: Building docker image <redacted>:latest.
04:59:18.63 [INFO] Completed: Building docker image <redacted>:latest.
04:59:18.64 [INFO] Built docker image: <redacted>:latest
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
๐ <redacted>:latest failed.DOCKER_HOSTDOCKER_HOSTm
modern-wolf-36228
11/30/2021, 2:17 PM Copy code
[docker]
env_vars = ["DOCKER_HOST"]pants.tomlh
hundreds-father-404
11/30/2021, 2:17 PMIf that fixes it, we should almost certainly add DOCKER_HOST to the default for that option
๐ 1
m
modern-wolf-36228
11/30/2021, 2:18 PMit fixed for me 3h ago ๐
โค๏ธ 1
h
hundreds-father-404
11/30/2021, 2:23 PMSweet! @modern-wolf-36228 any interest in submitting a PR? You would simply add default=["DOCKER_HOST"] to the relevant option in docker_options.py
n
narrow-vegetable-37489
11/30/2021, 2:24 PMAlready have it in my pants.toml sadly, still happens ๐
Copy code
[docker]
env_vars = [
"DOCKER_HOST",
]h
hundreds-father-404
11/30/2021, 2:24 PMNote that we should only have it be in the default, we should not hardcode that DOCKER_HOST is always autopopulated. It's important users can override what the value is set to
n
narrow-vegetable-37489
11/30/2021, 2:25 PMIf I remove
env_varspants.toml./pants packageenv_vars./pants publishh
hundreds-father-404
11/30/2021, 2:28 PMHm it looks like the env vars are being set: https://github.com/pantsbuild/pants/blob/main/src/python/pants/backend/docker/goals/publish.py
You could run with -ldebug to see the argv and env vars that are being used to publish. Or --no-process-execution-local-cleanup and inspect the __run.sh script
n
narrow-vegetable-37489
11/30/2021, 2:30 PMWill do!
narrow-vegetable-37489
11/30/2021, 2:41 PMSeems like I'm running a version of Pants (2.8.1rc0) where this fix isn't available: https://github.com/pantsbuild/pants/pull/13669
๐ 1
h
hundreds-father-404
11/30/2021, 2:59 PMGood find! Sounds like we should cherry-pick that PR
โ
1
โ 1
c
curved-television-6568
11/30/2021, 3:05 PMIt does have the
needs-cherrypick๐ 1
w
witty-crayon-22786
11/30/2021, 5:47 PM@curved-television-6568: if you wouldnโt mind doing the cherry-pick, iโd be happy to do the release
c
curved-television-6568
11/30/2021, 5:48 PMSure thing. I'll do it later tonight. Thanks :)
curved-television-6568
11/30/2021, 7:57 PM@witty-crayon-22786 https://github.com/pantsbuild/pants/pull/13752
w
witty-crayon-22786
11/30/2021, 7:57 PM๐ข
witty-crayon-22786
11/30/2021, 7:58 PMiโll try to get another 2.8.x prepped in my tonight
๐ 1
๐ 1
witty-crayon-22786
12/01/2021, 6:12 AM5 Views