What is the logic for trimming ` pants d pants log` when pan Pants #general

What is the logic for trimming `.pants.d/pants.log...

polite-garden-50641

01/13/2022, 8:07 PM

What is the logic for trimming

.pants.d/pants.log

(when pantsd is active) ? How to we make pants keep more data in this log? Running in CI, I noticed this file only contains logs from the last few steps that run in CI before the file was uploaded and it is missing log message from pants run that occur earlier on in the CI Job.

polite-garden-50641

01/13/2022, 10:38 PM

@witty-crayon-22786

witty-crayon-22786

01/13/2022, 10:41 PM

i believe that it used to be kept indefinitely, but it does appear to be the case right now that every time

pantsd

is restarted, it is cleared

witty-crayon-22786

01/13/2022, 10:42 PM

that… should probably be considered a bug.

👍 1

witty-crayon-22786

01/13/2022, 10:45 PM

hm. but the most obvious location for it to be cleared doesn’t appear to be: https://github.com/pantsbuild/pants/blob/b80eb7cfae31b5b4c8f2722a8a938117ffafbe48/src/rust/engine/logging/src/logger.rs#L79-L83 … the

append(true)

there should cause us to append to an existing file.

polite-garden-50641

01/13/2022, 10:55 PM

I see this behavior in our internal CI, so I will provide links and info over in our internal slack.

witty-crayon-22786

01/13/2022, 10:55 PM

I think it repros locally, so no need

witty-crayon-22786

01/13/2022, 10:56 PM

Thanks though.

polite-garden-50641

01/13/2022, 10:57 PM

got it.

polite-garden-50641

01/13/2022, 11:15 PM

https://github.com/pantsbuild/pants/issues/14167

Open in Slack

Previous Next