Is there a way to limit the depth of `--changed-de...
# generalh
high-yak-85899
02/10/2022, 8:49 PMIs there a way to limit the depth of
--changed-dependeesb
bitter-ability-32190
02/10/2022, 8:52 PMNot that I'm aware of.
bitter-ability-32190
02/10/2022, 8:53 PMFWIW I'd love to see more customizability in
--changed-dependeesh
high-yak-85899
02/10/2022, 8:54 PMYeah, I didn't see it in the docs, but I just intentionally made the argument wrong for that and saw that none, direct, and transitive are available.
high-yak-85899
02/10/2022, 8:54 PMimo, transitive seems to go way too deep to be useful for the target selection once repos start to get really large.
high-yak-85899
02/10/2022, 9:03 PMooo, I thought of something tricky for how you can do it
high-yak-85899
02/10/2022, 9:03 PMI remembered reading about piping arguments
high-yak-85899
02/10/2022, 9:03 PMSo I can do
Copy code
./pants --changed-since=master --changed-dependees=direct list | xargs ./pants dependees | xargs ./pants testh
hundreds-father-404
02/10/2022, 9:11 PMHm, you do need to traverse fully for correctness though.
./pants --changed-since=HEAD --changed-dependees=transitive test ::h
high-yak-85899
02/10/2022, 9:13 PMI want to minimize the amount of time it takes a developer to put up a change. Our build system will do the potentially heavier full validation for them because it has remote caching set up and can share work more easily. We haven't enabled remote caching for developer machines yet until we get more confidence of the load on that system.
high-yak-85899
02/10/2022, 9:13 PMSo, I'd like to run enough tests that should indicate things will probably work and then let devs respond appropriately if CI disagrees.
👍 1
high-yak-85899
02/10/2022, 9:14 PMSince we develop in multiple languages, it can be a while since someone has run tests in this portion of the repo and their cache would be so out of date that they'd have to run everything.
w
witty-crayon-22786
02/10/2022, 9:28 PMthe double-dependees thing is a neat trick, heh. but yea, those goals could probably pretty easily support a numerical level
h
happy-kitchen-89482
02/10/2022, 11:51 PMYeah that seems like a reasonable thing to support, if you want to put up a change? :)
h
high-yak-85899
02/10/2022, 11:52 PMlol, I'm building up quite the queue. When things cool down on the Astranis side (will it ever?) I'll start poking around the contributor page and get acquainted. This seems more reasonable to tackle as a first task than getting pyright type checking supported.
h
hundreds-father-404
02/10/2022, 11:54 PMHaha I feel you there, so many changes I want to do too.
Would you be willing to open a feature request please, including your (very helpful!) explanation for why this would be useful? In case anyone else wants to chip in
h
high-yak-85899
02/10/2022, 11:55 PMYeah, good idea. Will do that now.
b
bitter-ability-32190
02/11/2022, 1:00 AMFWIW contributing is super easy and fun. Would recommend 😉
🙌 1
🚀 1
h
hundreds-father-404
02/11/2022, 1:03 AMin general, we're very happy to pair program on any changes also 🙂
(altho ack the issue here is time, no pressure at all! there's never an expectation you contribute certain things)
h
happy-kitchen-89482
02/11/2022, 1:28 AMThis would definitely be a better first ticket to get your feet wet on
happy-kitchen-89482
02/11/2022, 1:29 AMIf I may mix metaphors atrociously
3 Views