So here is my fist batch of questions. Q1: I have

packages/common/pyproject.toml

. I'd like to refer this in`src/ai/backend/common/BUILD` 's

resource

command, either in relative paths or absolute paths (based on the root), but it says it's not allowed. Is copying

pyproject.toml

to

src/ai/backend/common

the only way? Q2: Is it possible to use existing

setup.cfg

and their

install_requires

configs in each project to specify 3rd-party dependencies per

BUILD

target? Q3: In

pants.toml

I could specify per-tool options such as

pytest.args

and

pytest.extra_requirements.add

. How do I specify per-tool per-project options as well? (e.g., each project requires different sets of

xxx-types

packages for type check) Q4: How to single-source the version across multiple distribution targets in a (Python-based) mono-repository?

A1: The rule is that a BUILD file may only have targets for files in its own directory or its subtree. Commonly, you have the target defintion, such as the

resource

in the BUILD file in the same directory as it’s sources. Rather than copying, you may add a dependency between your

resources

, so there may be a

resource

in your ai backend with a dependency to the resource from your common tree. (dependencies may go any where, so are not restricted the same way as sources are)

About A2, is it sufficient to specify

setup.cfg

as a dependency of

python_distribution()

?

Not sure. Perhaps @happy-kitchen-89482 has the answer to that one.

About A3, hmm... since

setup.cfg

has

extra_requires

for

test

,

typecheck

,

lint

, etc., it would be best to reuse them if possible.

I’ll give hints at what I have, and leave the rest for the other maintainers to fill in the gaps 🙂

Hm... About A1, I've tried this, but it still says

NoOwnerError: No python_distribution target found to own packages/common:pyproject. Note that the owner must be in or above the owned target's directory, and must depend on it (directly or indirectly). See <https://www.pantsbuild.org/v2.12/docs/python-distributions> for how python_sources targets are mapped to distributions. See <https://www.pantsbuild.org/v2.12/docs/python-distributions>.

Ah, yes, as the message is hinting at, the python_distribution must live as an umbrella for all sources it includes. It’s a little different for distributions than resources. For more info, see: https://www.pantsbuild.org/v2.11/docs/python-distributions#mapping-source-files-to-distributions

hmmm so it still requires the pyproject.toml to be placed under the same directory because it infers the "closest ancestry" and in my case it becomes the root directory

Uhm, yes, it seems so. Another question, do you intend to ship the pyproject.toml with multiple distributions? (I think it may complain if you have the same files be part of more than one distribution)

I'd like to have separate pyproject.toml (or setup.cfg) per distribution

If you have your dependencies listed in your pyproject.toml (as done by Poetry for instance), you don’t need requirements.txt files. (if that helps) https://www.pantsbuild.org/v2.11/docs/python-third-party-dependencies#poetry

yeah, but I want to unify the requirements and let individual distributions have the requirements that they really depend on only, if possible.

That’s a good goal. What are doing with the pyproject.toml in the distribution?

the reason is to keep consistency of 3rd party dependencies across different distributions because they also relies on each other

If those are in the same monorepo, there’ll be dependencies for them automatically. Ah, when generating setup.py, I have no experience with when you provide setup.py yourself.

i'm not sticking with pyproject.toml until PEP-621 finally arrives

I think the easiest would be to have the pyproject.toml file closer to the python_distribution target

Yeah IIRC the

setup.cfg

would need to be in a

resources()

target that the

python_distribution()

target depends on