Hi team, a (hopefully) quick question on `--change...
# generalw
wide-zoo-86070
05/03/2022, 4:35 PMHi team, a (hopefully) quick question on
--changed-dependeesunit/A_test.pyunit/B_test.pyA_test.py/pants --changed-since=origin/master --changed-dependees=transitive testB_test.pyA_test.pyunit/BUILDh
hundreds-father-404
05/03/2022, 4:35 PMDid you modify the build file directly?
w
wide-zoo-86070
05/03/2022, 4:35 PMno, I only modified A_test.py
h
hundreds-father-404
05/03/2022, 4:36 PMw
wide-zoo-86070
05/03/2022, 4:45 PMthe path command does not seems working on test modules?
h
hundreds-father-404
05/03/2022, 4:46 PMhow so? you should be able to do
./pants paths --from=helloworld/tests_a.py --to=helloworld/tests_b.pyw
wide-zoo-86070
05/03/2022, 4:46 PM Copy code
./pants paths --from=project_a/test_helloworld/unit/greeting_test.py --to=project_a/test_helloworld/unit/translator_test.py
12:45:13.69 [ERROR] 1 Exception encountered:
ResolveError: 'unit' was not found in namespace 'project_a/test_helloworld/unit'. Did you mean one of:
:testswide-zoo-86070
05/03/2022, 4:47 PM Copy code
python_tests(name="tests", tags=["unit_test"])h
hundreds-father-404
05/03/2022, 4:50 PMwhich Pants version is this? You might need to do this:
Copy code
./pants paths --from=project_a/test_helloworld/unit/greeting_test.py:tests --to=project_a/test_helloworld/unit/translator_test.py:testshundreds-father-404
05/03/2022, 4:50 PMI think it used to require target addresses, and Benjy improved it to work with just file paths too in a newer Pants version
w
wide-zoo-86070
05/03/2022, 4:51 PM Copy code
./pants paths --from=project_a/test_helloworld/unit/greeting_test.py:tests --to=project_a/test_helloworld/unit/translator_test.py:tests
12:51:33.24 [ERROR] 1 Exception encountered:
ValueError: The destination is not a dependency of the sourcewide-zoo-86070
05/03/2022, 4:52 PMit shows that translator_tests.py has no relationship with greeting_test.py.
wide-zoo-86070
05/03/2022, 4:53 PMbut if I modified greeting_test.py only, with the
--changed-dependees./pants --changed-since=origin/master --changed-dependees=transitive testh
hundreds-father-404
05/03/2022, 4:56 PMhm fishy. What if you do
./pants --changed-since=origin/master listgreeting_test.pyw
wide-zoo-86070
05/03/2022, 4:56 PM Copy code
./pants --changed-since=origin/master list
project_a/test_helloworld/unit/greeting_test.py:testsh
hundreds-father-404
05/03/2022, 4:57 PMK, then
./pants dependees --transitive project_a/test_helloworld/unit/greeting_test.py:testsw
wide-zoo-86070
05/03/2022, 4:58 PM Copy code
./pants dependees --transitive project_a/test_helloworld/unit/greeting_test.py:tests
project_a/test_helloworld/unit:tests👍 1
h
hundreds-father-404
05/03/2022, 4:59 PMthat's what I would expect. and how about
./pants dependencies --transitive project_a/test_helloworld/unit/translator_test.py:testsw
wide-zoo-86070
05/03/2022, 4:59 PMso isn’t it because they shared the same BUILD files, in particular,
python_tests(name="tests", tags=["unit_test"])h
hundreds-father-404
05/03/2022, 4:59 PMNo, that should not matter unless you directly changed the BUILD file
w
wide-zoo-86070
05/03/2022, 5:09 PM Copy code
./pants dependencies --transitive project_a/test_helloworld/unit/translator_test.py:tests
//:dev#pytest
//dev-requirements.txt:dev
project_a/helloworld/translator/translator.pyh
hundreds-father-404
05/03/2022, 5:11 PMokay you are right, I'm experiencing the same thing that
./pants list./pants testw
wide-zoo-86070
05/03/2022, 5:12 PMno problem. Let me know if the issue so I can track it. Thank you!
h
hundreds-father-404
05/03/2022, 5:15 PMhundreds-father-404
05/11/2022, 2:57 AMI want to write good tests for this before landing to make sure we really really understand what's going on. But: https://github.com/pantsbuild/pants/issues/15313
2 Views