brash-baker-91190
05/03/2022, 6:20 PM./pants filter --target-type=python_tests :: | xargs ./pants --tag="-e2e" test
. This worked fine with 2.10.0 and appears to have started failing with 2.11.0.dev0
. The failure comes with the tag-based filter: my tests that are tagged as "e2e" tests (which I don't want to run in CI when I'm trying to do unit tests, since they rely on external infrastructure resources) are also being run, and are not being filtered out. Even taking out the xargs
bit and just running ./pants --tag="-e2e" test ::
fails.
Has anyone encountered something similar? Any pointers on how to deal with this? Thanks 🙇hundreds-father-404
05/03/2022, 7:00 PMpython_test
w/o the s. The tags get copied to each generated targetbrash-baker-91190
05/03/2022, 8:01 PM./pants --tag="-e2e" filter --target-type=python_test :: | xargs ./pants test
works... had to shift the --tag
option to the filter
command, though.hundreds-father-404
05/10/2022, 8:37 PMtags
field? Can you please share a sample BUILD file?brash-baker-91190
05/10/2022, 9:19 PMpython_tests(tags=["e2e"])
hundreds-father-404
05/10/2022, 9:33 PMbrash-baker-91190
05/10/2022, 9:33 PMhundreds-father-404
05/10/2022, 10:40 PMtags
a moved field, which means that now the target generator does not have tags
-> --tag=-bad
does nothingwitty-crayon-22786
05/10/2022, 10:41 PMhundreds-father-404
05/10/2022, 10:42 PMwitty-crayon-22786
05/10/2022, 10:42 PMhundreds-father-404
05/10/2022, 10:43 PMtags
and description
should be moved rather than copied? I see no benefit. Not like you're gonna parametrizewitty-crayon-22786
05/10/2022, 10:44 PMhundreds-father-404
05/10/2022, 10:46 PM./pants --tag=-bad filter --target-type=python_tests ::
to still filter how folks would expectwitty-crayon-22786
05/10/2022, 10:50 PM./pants --tag=-bad filter --target-type=python_tests ::
would still break for python_sources(overrides={'one.py': {'tags': ['bad']}})
hundreds-father-404
05/10/2022, 10:53 PMpython_tests
is the sole target type where we move rather than copy. I think it was oversight❯ ./pants --tag='demo' list 'src/python/pants/util/*util*.py'
src/python/pants/util/strutil_test.py:tests
14977 remains a head scratcher for me