rhythmic-glass-66959
07/27/2022, 5:24 PMsdist
doesn't contain any sources. Any ideas of what could be the problem? I have the python_sources
target defined...wide-midnight-78598
07/27/2022, 6:01 PM.py
files in that folder -should- be picked up.
That's not happening?rhythmic-glass-66959
07/27/2022, 6:04 PMwide-midnight-78598
07/27/2022, 6:07 PMrhythmic-glass-66959
07/27/2022, 6:07 PMpython_distribution(
name="dist",
dependencies=["src/python/my_package"], <--- Need this or no sources are included in the sdist
provides=python_artifact(
name="my_package",
version="0.1.0",
),
)
python_sources()
wide-midnight-78598
07/27/2022, 6:08 PMpython_sources
wasn't working. The dependency makes senserhythmic-glass-66959
07/27/2022, 6:09 PMwide-midnight-78598
07/27/2022, 6:11 PMrhythmic-glass-66959
07/27/2022, 6:14 PMpants
and I don't understand all its concepts yet...wide-midnight-78598
07/27/2022, 6:15 PMhappy-kitchen-89482
07/27/2022, 9:00 PMpython_sources
is what owns the sources. The python_distribution
is a layer on top that says, "package these sources into a distribution". There is no way to infer what "these sources" are.python_sources
?python_sources
in that dir?rhythmic-glass-66959
07/27/2022, 9:06 PMpython_sources
own the sources. If there's a python_distribution
inside the same BUILD file, why it cannot package those sources into the distribution?python_sources
inside the directory. I have mixed feeling about this... Maybe because I do not have much experience with Pants
.happy-kitchen-89482
07/27/2022, 10:57 PMAs you said, the python_sources own the sources. If there's a python_distribution inside the same BUILD file, why it cannot package those sources into the distribution?It could if we assumed that a
python_distribution
by default depends on any sibling python_sources
, without an explicit dep. But we've just not made that assumption in the past...wide-midnight-78598
07/28/2022, 12:03 AMhappy-kitchen-89482
07/28/2022, 12:22 AM