Hello, I'm fixing dependencies in my project as right now, I'm pulling everything for everything and Pants seems to have some issues inferring some dependencies with pytest and pytest-mock. I'm having lines like

@pytest.fixture(autouse=True)
def dont_do_this(mocker):
    mocker.patch("my.module.class.method")

and Pants doesn't seem to add

my/module.py

in the dependencies even with

[python-infer]
string_imports = true

Am I missing something or should I manually add those deps in my BUILD file?

Are you putting

pytest-mock

in your

pytest

extra_requirements

? Then it's in every test execution/sandbox: https://www.pantsbuild.org/v2.13/docs/python-test-goal#pytest-version-and-plugins

Sorry, my message wasn't complete I just modified it 😕 I do have

pytest-mock

in the config.

I think that as the string contains a class and a method, this isn't just a "string_import" so I guess pants ignores it. This is just hypothesis, I haven't check the code

Yup was just about to say that coke

I have one case where the patching is on the conftest.py to disable a function that is costly and not needed on the tests. As it is an "auto used fixture", virtually all tests use it

I don't think that answers my question. Either the code-under-test doesn't depend on the thing being patched, in which case we're OK. Or it does and so it gets patched. I'm not seeing the issue

conftest is loaded no matter what. So the call to mocker.patch will happen no matter what test

Does the patch call fail if the module isn't found?

yes and that makes the whole suite to fail

Oh yeah, that piece of info was missing 🙈

well, that's actually a nice idea

HOW AM I JUST LEARNING ABOUT THIS?!?!