bitter-ability-32190
08/16/2022, 4:30 PMupdate-build-files
into `fmt`/`fix`.
• Let's say you're formatting your build files with black
. Running ./pants fmt --only=black ::
with `black`en your Python code AND your BUILD
files. How does that feel, as a user? The alternative is to make some "special" key (like build-files-black
or similar), which feels worse to me.
• Do we need/want options for "only BUILD files"/"everything but build files"? Those are possible, but tricky to find a good name for IMO.happy-kitchen-89482
08/16/2022, 4:32 PM::
to format by BUILD files as well as my python codebitter-ability-32190
08/16/2022, 4:34 PM--only
part, not the specs part. Even though using black to format BUILD files will be opted in, is the user ready for --only=black
to format non-Python files?happy-kitchen-89482
08/16/2022, 4:35 PMhappy-kitchen-89482
08/16/2022, 4:35 PMhappy-kitchen-89482
08/16/2022, 4:35 PMhappy-kitchen-89482
08/16/2022, 4:35 PMbitter-ability-32190
08/16/2022, 4:35 PMbitter-ability-32190
08/16/2022, 4:38 PMwide-midnight-78598
08/16/2022, 4:39 PMbitter-ability-32190
08/16/2022, 4:40 PMwitty-family-13337
08/16/2022, 4:40 PMBUILD
files affected by itflat-zoo-31952
08/16/2022, 4:52 PMbitter-ability-32190
08/16/2022, 4:54 PM...
backend_packages = [
...
"build_files.fmt.black",
....
]
flat-zoo-31952
08/16/2022, 4:54 PMflat-zoo-31952
08/16/2022, 4:54 PMfmt --only=black
formatting build files makes sense if you have that backend enabledbitter-ability-32190
08/16/2022, 4:55 PMflat-zoo-31952
08/16/2022, 4:55 PMbitter-ability-32190
08/16/2022, 4:55 PMname
is 'black'"bitter-ability-32190
08/16/2022, 4:56 PMbitter-ability-32190
08/16/2022, 4:56 PMflat-zoo-31952
08/16/2022, 4:56 PMupdate-build-files
since it's a different autofixer than what you would use to fix
python stuffbitter-ability-32190
08/16/2022, 4:57 PMflat-zoo-31952
08/16/2022, 4:58 PMbitter-ability-32190
08/16/2022, 4:59 PMupdate-build-files
. It'll be an undocumented goal, which just calls into the new code. We can discuss deprecation/removal separately 🙂wide-midnight-78598
08/16/2022, 5:13 PMIt'll be an undocumented goalAs in,
update-build-files
docs would be removed?bitter-ability-32190
08/16/2022, 5:14 PMfmt
and fix
wide-midnight-78598
08/16/2022, 5:16 PMbitter-ability-32190
08/16/2022, 5:17 PMwide-midnight-78598
08/16/2022, 5:17 PMbitter-ability-32190
08/16/2022, 5:22 PMflat-zoo-31952
08/16/2022, 5:32 PM