It looks like the

fix

goal does not exit with

1

in case it fixed something. Is this intended behaviour? The

lint

goal does behave differently here. We have configured the following alias

valid = "tailor --check fix lint check"

Which we also use in our CI pipeline. Since the

fix

goal fixes everything before the

lint

goal runs and it does not exit with

1

we did not notice some style issues on some of our PRs.

The lint goal runs all fixers/formatters to see if anything will change, so you only need

lint

in CI

Yes I know, but for local development we automatically want to fix all issues. For consistency we want to use the same command in our CI pipeline as well.

The latter part sounds slightly nonsensical here. You want CI to edit files? I'd think you want it to confirm no edits are needed.

(also ideally devs run

tailor

without

--check

)

hm, I see your point. The upstream packaged (black, isort, etc.) behave the same. I guess we did start doing it this way because we previously used pre-commit for the fixers which exited with code 1 if something was fixed. Thanks for the clarification!