https://pantsbuild.org/ logo
Join Slack
Powered by
Even though I "work here", I am still confused abo...
# general
h
Even though I "work here", I am still confused about 
fix
vs 
fmt
. Can someone remind me what's up with that?
e
IIRC 
fmt
is a subset of 
fix
but either 
fmt
was deemed important enough to keep (don't break people) or there were a mix of solid consistent formatters out there but not so more general fixers? I know 
cargo clippy --fix
is solid but I can imagine yolo fixers out there, especially in Python.
If so, green field, this smacks of the same issue as export - blanket goal where you want to sub-selct impls / resolves, etc.
b
The razor was 
--loop
. Not safe to loop on fix, but safe to loop on fmt
e
That's not true of clippy --fix
And fmt is not safe to loop on either - you can type a few characters and have invalid syntax which will kill cargo fmt
b
The mirror then would've been 
pants lint --fix
which was voted down
e
Ok. It sounds like basically a bikeshed. No solid reasons / razors. Vote, done. Is as it is.
👎 1
b
The discourse was public...
e
Basically a sin here is the whole idea of goals. It gets between people and their tools. Can be good can be bad
h
I remember the discourse, I just didn't remember the conclusion
e
I can't just run pylint, I have to run lint and everything hooked up or use awkward ad-hoc skips that just work around the goal concept anyhow.
h
So do I need to run 
fmt
and `fix`for completeness?
b
Fix fixes everything (by also running formatters)
h
Ah, OK
perfect
e
FWIW I just run fix fmt lint check test because I never know and will never remember the ~arbitrary nuance.
h
so I just need to remember 
fix
e
good luck!
😄 1
h
My brain is one-in-one-out at this point. If I can insert 
fix
into the slot previously held by 
fmt
, it's all good. If I have to remember both, I will forget how to tie my shoelaces or something.
😂 1
e
I personally have a hard tie because I use pants a minority of the time. cargo a majority these days - where fmt is a thing and fix is not, and tox more than Pants where you pick the name.
Really, if you run support you need to 
fmt fix
and then when that errors, you subtract 
fix
since fix did not always exist.
5 Views
Open in Slack
PreviousNext
Powered by