https://pantsbuild.org/ logo
#general
Title
# general
c

cool-yacht-37128

03/07/2023, 11:46 PM
Has anyone been able to use
vcs_version
with
go_package
? Seems like it doesn’t infer the codgen’d go package dependency and explicitly stating the dependency doesn’t work either
Untitled
this
vcs_version
generates a valid go package with the variable
VER_STRING
but thats as far as I can get.
h

happy-kitchen-89482

03/08/2023, 3:40 AM
Hmm, we've only really tested this for generating a Python version file, so I can imagine there might be issues. Can you put together a small repo that demonstrates the problem? Then I can take a look.
👍 1
c

cool-yacht-37128

03/08/2023, 4:44 AM
h

happy-kitchen-89482

03/15/2023, 3:00 AM
I finally got around to looking at this
Have reminded myself of how the vcs_version code works
and yeah, right now its outputs will only get chained correctly if they are python sources
Will see what it would take to change that
c

cool-yacht-37128

03/15/2023, 4:18 AM
Awesome, thanks for looking into this one.
Hi @happy-kitchen-89482, What do you think this? Do you want me to submit an issue?
h

happy-kitchen-89482

04/04/2023, 5:23 PM
Yeah, an issue would be great. I don't think this is a trivial fix.
👍 1
c

cool-yacht-37128

04/05/2023, 12:32 AM
Thanks for having a look. I’ve submitted an issue here: https://github.com/pantsbuild/pants/issues/18684