I was confused by timezones, I thought tomorrow me...
# development
d
I was confused by timezones, I thought tomorrow meant today (Tuesday 15th), so I seems I missed the develop meeting. I would have liked to talk about my two open PR: • github.com/pantsbuild/pants/pull/23668 • github.com/pantsbuild/pants/pull/23620
h
Ah yes, sorry those took a while to get to. My personal life is a bit chaotic right now (in a good way!) I just approved and merged https://github.com/pantsbuild/pants/pull/23668 after going over the design doc and commenting there.
d
hey, sorry to hear life is chaotic in a good way. I do appreciate working this kind of open source project is a lot of effort for not much reward.
once the other pr, is merged we plan to start working the pants Scala migration for a fairly large data analytics focused repo. I kinda suspect we going to need to open a few PRs, so I'm wondering if you had any opinions we can make the operation as efficient as possible for everyone involved?
@fierce-truck-19259 any chance you can look at github.com/pantsbuild/pants/pull/23620 I think we might be there now
f
Yeah, I think it looks fair, I'm wondering if you explored the possibility of having a threshold for when this kicks in, to avoid the extra Digest write on everything that don't have a very long arg list, or if we should make it configurable if there would be any compatibility issue for someone with the arglist via file? I'm just wondering because there so much going into 2.34 now that it is just a slight concern if it could risk blocking that upgrade for someone, especially if they're not affected by the arglist issue
The fix itself I think looks good, just thinking about whether it would be worth containing it any more since it's so central on JvmProcess
d
the change to only use the file over a certain threshold seems quite simple so I added it to the PR: github.com/pantsbuild/pants/pull/23620/…/123ae0896e5c…
I chose quite a low threshold to try and cover more environments than just linux
so, is the safe guard I've added enough?
h
cc @fierce-truck-19259