Hi! We have 3 PRs open on JVM areas that are quite...
# development
f
Hi! We have 3 PRs open on JVM areas that are quite substantial enablers. Reduces CI build times for JVM by up to 80% with remote cache, unblocks nailgun support for JDK versions past 17 and adds source jars which enables development on metals (VS code etc). I understand times might be busy with PRs nowadays, but if it was possible to get eyes on these it would greatly benefit JVM usage https://github.com/pantsbuild/pants/pull/23408 https://github.com/pantsbuild/pants/pull/23405 https://github.com/pantsbuild/pants/pull/23410
w
@fierce-truck-19259 Yeah, I think our issue here is capability on JVM reviews. I can review and maybe have some superficial opinions, but I'm not the best to review. I'm not sure off-hand if there are other people who are JVM people. Aside: We have some scala PRs as well, do you think you could give those some eyeballs? https://github.com/pantsbuild/pants/pull/22921 ... and I thought there were more, but I think the other one is a draft still
h
I'll take a look, and also see what Claude has to say.
w
I'll be looking at the two smaller ones this evening, not sure if I’ll make it to the larger ones with the other PRs I have to review tonight
f
Thank you for taking a look! Sure I can check it out 🙂
Added a comment on that scalameta PR, it looked fine to me