https://pantsbuild.org/ logo
Join Slack
Powered by
Alright, finally back to this 3.14 internal Python...
# development
w
Alright, finally back to this 3.14 internal Python update. Targeting to get it into 2.32 finally https://github.com/pantsbuild/pants/pull/22816
f
Any objection to an immediate dev release with this in it?
Would love to port my opentelemetry plugin to support it.
w
Has to pass the PR
But no
Internal Python 3.14 merged to main. There are associated cleanup tasks - but this is a good time to check if there are bugs not captured by our test suite
f
Thanks for doing the upgrade!
w
👍
And now... We pray to the Python gods to keep Pants safe from my mistakes
f
If this was Perl, you could just 
bless
the code.
How do you want post 3.14 integration issues reported?
Some warnings from third-party dependencies:
Untitled
w
f
Ok you've captured the ones I'm seeing
w
I think the FastAPI stuff is the explorer, which I'm likely going to strip out to a separate plugin. It's not used, and it's bitrotted - I wasn't able to quickly get it up and running. So, we can re-intro it later, but I think it's gotta go
f
AttributeError: 'builtins.PyStdioRead' object has no attribute 'close'
is preventing 
fmt
from running completing successfully.
w
It shouldn't have. I've been getting that and passing CI, and running. It's a surfaced error from what I recalled.
I'll check again tonight when I'm back at my machine - I wanted to deal with at least one of those two deprecations/errors - but I've been getting that since day 1 of the 3.14 upgrade
f
I will see what the exit code was.
I just know that I was trying to run 
./pants fmt lint check src/python::
with a bug fix PR and needing to investigate on why it didn't fully complete
yeah the close one seems to be ignored
sent a PR to "fix" it in any event
and my PR needed a 
pants fix
, annoying that 
fmt
didn't run import sorting
Open in Slack
PreviousNext
Powered by