https://pantsbuild.org/ logo
Join Slack
Powered by
Are these Rust-on-MacOS test failures ringing any ...
# development
h
Are these Rust-on-MacOS test failures ringing any bells? https://github.com/pantsbuild/pants/actions/runs/18458029245/job/52635427810?pr=22741
Copy code
failures:
    local_tests::garbage_collect_and_compact
    local_tests::remove_big_file_and_store_again
These fail locally for me (on macos) even on 
main
w
Weird error - was there some compression lib change or something?
The change looks innocuous
h
Yeah, and as I said this fails even on 
main
Which means probably not due to a code change ?
I'm not sure what changed, but these tests were janky to begin with. They were making assumptions about LMDB store size under various conditions that are not guaranteed by anything.
this now fails if I sync back a full 12 months, so this isn't due to a code change.
So we're left with OS change
And again, I can fix these my just fiddling with the expected numbers, as these are janky tests to begin with
Hmm so at least on macos 14 even if I comment out all the writes to LMDB in the test, the empty LMDB is more than 2MB on disk. So this may be due to differences in how macos 14 reports files sizes for mmapped files
w
Did the macOS 14 change under the hood?
h
Yep, and that test only runs on rust changes, so this was probably the first such change since the OS change
7 Views
Open in Slack
PreviousNext
Powered by