Hey! I would love if I could get a couple of eyes ...
# developmentf
fierce-truck-19259
10/03/2025, 4:25 PMHey! I would love if I could get a couple of eyes on https://github.com/pantsbuild/pants/pull/22726, it makes a pretty significant impact for any sizable Go project
🤯 1
f
fast-nail-55400
10/03/2025, 6:20 PMLooks fine. I marked it for back-port to 2.27,28,29. Thanks for finding!
🙏 1
h
happy-kitchen-89482
10/03/2025, 10:11 PMWonderful stuff @fierce-truck-19259!
f
fast-nail-55400
10/04/2025, 4:24 PMLooks like the backports failed to apply.
h
happy-kitchen-89482
10/04/2025, 9:16 PMYeah, mostly due to the 2.30.x notes file not being present
happy-kitchen-89482
10/04/2025, 9:16 PMI sorted it out manually
f
fast-nail-55400
10/04/2025, 9:41 PMThat’s odd since I had modified the back port script to delete the latest release notes file.
h
happy-kitchen-89482
10/04/2025, 10:44 PMIn the 2.27 case there was also a real diff, but in the other two it was just that
6 Views