Just ranting: We have some nasty effective depende...
# developmenth
happy-kitchen-89482
08/28/2025, 7:53 PMJust ranting: We have some nasty effective dependency cycles in the options bootstrapping code that were hidden due to call-by-type, but switching to call-by-name exposes them as import cycles
happy-kitchen-89482
08/28/2025, 7:56 PMFor one thing,
Subsystem@pants.engine.rule.ruleSubsystem.rules()pants.engine.rulecollect_rules()Subsystemhappy-kitchen-89482
08/28/2025, 7:56 PMAnd each of those are imported in over 400 files, so splitting them up would be annoying
happy-kitchen-89482
08/28/2025, 7:57 PMI think maybe I can change the logic in
collect_rules()Subsystemhappy-kitchen-89482
08/28/2025, 7:57 PMAnd now the call-by-name tide is out, and we’re seeing which packages were swimming naked…
w
wide-midnight-78598
08/28/2025, 8:34 PMYep, I ran into something like this when I yolo'd CBN a while back. The more core we went, the more of these shenanigans that happened
h
happy-kitchen-89482
08/30/2025, 12:44 AMThis refactors the problem away, and it was not fun: https://github.com/pantsbuild/pants/pull/22599
🚢 1
happy-kitchen-89482
08/30/2025, 1:10 AMAnd causes all the tests to fail… one sec
happy-kitchen-89482
08/30/2025, 4:04 PMOK, good to go now
9 Views