https://pantsbuild.org/ logo
Join Slack
Powered by
Is there any plans to support migrating plugins an...
# development
a
Is there any plans to support migrating plugins and unit tests to call-by-name via the 
migrate-call-by-name
rule? I know some of the unit test stuff was still being ironed out. I'd also be happy to contribute in this area. I'd like to get the plugins in my work repo migrated at some point so junior devs can actually follow what's going on without in-depth Pants knowledge.
Also @happy-kitchen-89482 I know this was something you were working on, curious if this has maybe been resolved in a later version? It's still an issue in 2.27 https://github.com/pantsbuild/pants/issues/21785
w
Is there any plans to support migrating plugins and unit tests to call-by-name via the 
migrate-call-by-name
rule?
Yes. The plan was once the cbn was pretty far along in case there are any hiccups. I think we're more than far enough along now, and the perf is 😗 🤌 This is explicitly one of the things stopping in-repo plugins using call-by-name, and yes, it was intentional at the time. Didn't want to deal with tickets about it https://github.com/pantsbuild/pants/issues/21044
I haven't checked in a long time how this works on other plugins (or call-by-name in general) - but it's definitely worth messing around
a
Yeah I saw that the other day, my quick read was that we could probably use absolute filepaths. I was going to test making the change actually but I have like...a ton of work for my actual job I need to get done so I didn't get around to it lol
w
Yep, welcome to the club 😂
So yeah, in general, it's definitely on the road map - but when specifically? 🤷
7 Views
Open in Slack
PreviousNext
Powered by