I'm MOTW this week. I've had minimal time for Pant...
# development
b
I'm MOTW this week. I've had minimal time for Pants recently, so am having to page everything back in right now: For upcoming releases: • We're just cutting 2.27.0 stable now (yay) • That suggests branching for 2.28 from main soon too. For older releases: • Looks like the milestone 2.24.x is still open, but most recent activity was 2.24.3 stable release 3 months ago. • 2.25.x and 2.26.x have had recent cherrypicks Thus, I think my release actions this week should be: • close the 2.24.x milestone (no further releases required) • do 2.25.x and 2.26.x releases (suggest rc then soon-after stable, given the cherrypick is "Add missing backends") • assist with 2.27.0 as required • branch for 2.28.x: do 2.28.0a0 release, create the 2.28.x milestone/branch, switch main to 2.29.x Any objections or thoughts?
Release preps, along those lines: • 2.25.3rc0: https://github.com/pantsbuild/pants/pull/22432 • 2.26.2rc0: https://github.com/pantsbuild/pants/pull/22431 • (2.27.0: Benjy is on this one) • 2.28.0a0: https://github.com/pantsbuild/pants/pull/22433 Please review if you have a second; thanks.
f
I had partially refactored the environments rules in 2.28.x
I would like to move the rules from pants.core.util_rules.environments to pants.core.environments.rules
Target types were already refactored there. So for consistency I should finish the refactor. (Refactor was for breaking a cycle which prevented call-by-name work.)
b
Thanks for doing the refactoring to unblock work. Are you saying that the rules should be moved in the 2.28.x release? (i.e. I should wait for that before branching?)
f
Probably better for consistency. to do before branching or just cherry pick it later.
b
I think we're ready to branch for 2.28.x; any additional requests/comments? If not, please review https://github.com/pantsbuild/pants/pull/22433
h
I would like to get one thing in to 2.28.x, but can cherrypick it
Specifically, turning sandboxer on in the pants repo, so we can get more experience using it and figure out its bugs
b
Thanks for doing that work. Turning it on in the Pants repo sounds good, but I wonder if it might be good to leave for main / 2.29.x It's not obvious to me what we'll learn from having it in 2.28.x today vs. in 2.29.x tomorrow, and having in 2.28.x might risk interfering with getting 2.28.0 stable out the door? That is, if it's in 2.28.x and there's issues, we might be blocked from doing 2.28 rcs and stable releases (at least until we debug enough to identify the problem is the sandboxer and turn it off) (Given it's cherrypickable either way, I'll get 22433 in and do the branching.)