<@U051221NF> What's the new convention with the ru...
# developmentw
wide-midnight-78598
05/15/2025, 2:19 AM@happy-kitchen-89482 What's the new convention with the rule_runner to handle MockGets? This call should already be mocked out in my code
wide-midnight-78598
05/15/2025, 2:20 AMOr is it just porting them to mock_calls?
wide-midnight-78598
05/15/2025, 2:27 AMYep, looks like just making them mock_calls was enough
h
happy-kitchen-89482
05/15/2025, 2:38 AMYep, mock_calls
happy-kitchen-89482
05/15/2025, 2:39 AMAlthough there appears to be a bug, this should just be a warning, but that
remove()happy-kitchen-89482
05/15/2025, 3:18 AMI don’t see how this can be possible. Do you have a branch that reproduces it?
w
wide-midnight-78598
05/15/2025, 3:19 AMIt was in the javascript one - but then I migrated everything to mock_call - you can undo that in test_test.py (I believe)?
wide-midnight-78598
05/15/2025, 3:19 AMwide-midnight-78598
05/15/2025, 3:20 AMActually, maybe in nodejs_test.py https://github.com/pantsbuild/pants/pull/22296/files#diff-b889e26d66ed100ff232e6630ee529a23162f8ec7eb84700f128ae99889d2017
h
happy-kitchen-89482
05/15/2025, 3:40 AMFixed here: https://github.com/pantsbuild/pants/pull/22297
4 Views