What should be done if a file has a "rule cycle" b...
# developmentf
fast-nail-55400
05/14/2025, 1:19 AMWhat should be done if a file has a "rule cycle" between two rules given the engine currently requires a referenced call-by-name rule to already be defined if called in the same file? https://github.com/pantsbuild/pants/pull/22269#pullrequestreview-2838435551
w
wide-midnight-78598
05/14/2025, 1:33 AMI had to split this out to a separate file when I had to do it, like I'm living in the stone age
f
fast-nail-55400
05/14/2025, 1:55 AMWill a rule cycle between two files work? At the very least, it'll be an import cycle and I'll likely have to hide the imports inside each function.
w
wide-midnight-78598
05/14/2025, 1:57 AMAs in, I had a 3rd utility file that other ones pulled in. It was for docker and I hated it.
f
fast-nail-55400
05/14/2025, 2:33 AMI'm encountering a rule cycle in core/system_binaries.py for the BashBinary rule
fast-nail-55400
05/14/2025, 2:33 AMI wonder how hard it would be to allow forward references for rules with call-by-name.
fast-nail-55400
05/14/2025, 2:37 AMw
wide-midnight-78598
05/14/2025, 2:40 AMIm guessing it will follow some of the hurdles of the rule_helper? As in, same limitations probably
wide-midnight-78598
05/14/2025, 2:40 AMMaybe there is prior art?
h
happy-kitchen-89482
05/14/2025, 2:45 AMI remember going deep into this about a year ago: https://github.com/pantsbuild/pants/pull/21174
happy-kitchen-89482
05/14/2025, 2:47 AMLong story short, this is hard
happy-kitchen-89482
05/14/2025, 2:49 AMAt least for now. Once we’re fully on call-by-name we can get rid of the thing that makes this hard…
happy-kitchen-89482
05/14/2025, 2:50 AMBut of course we can’t do that until we port this to call-by-name, so chicken meet egg
🐔 2
🍳 2
5 Views