A little tech debt cleanup, if anyone wants to do ...
# development
h
A little tech debt cleanup, if anyone wants to do a quick review: https://github.com/pantsbuild/pants/pull/22129
๐Ÿ‘ 1
p
What is the
src/python/pants/bin/sandboxer
binary you added? It's not referenced by any of the tests you changed that I can see. https://github.com/pantsbuild/pants/pull/22129/files?diff=unified&w=1#diff-427d502278832451dbc9f4a80e6fa0480692586f2832c2d30cb318ae0e899b84
w
Good call, I missed that - was looking at the tests, and the binary diff was so small
h
Oh whoops!! How did that get in there
๐Ÿ‘ 1
yikes
that is a work in progress
p
So, another PR to remove it?
h
๐Ÿคฆ
In case youโ€™re curious,
sandboxer
is a sidecar process I am working on that materializes from the store into the sandbox, to finally properly solve https://github.com/pantsbuild/pants/issues/19318
Which are all the same problem, we just never fixed it fully properly
p
Interesting ๐Ÿ™‚
h
Yes, although that was just a draft for feedback, the upcoming PR will incorporate that feedback
โค๏ธ 1
p
I'm glad you are working on things like this. Those issues look mind bending. Thank you!