I’m ensuring the common github actions we use (upl...
# development
h
I’m ensuring the common github actions we use (upload/download-artifact, checkout, setup-node and a couple of others) are updated in active release branches, ahead of potential deprecations or planned failures (for example, upload/download-artifact at
v3
will stop working end of January).
In the 2.24.x branch we distinguish
node16_compat
from not, and in the former case we use, e.g.,
actions/upload-artifact@v3
. But as mentioned, that will stop working soon. I would be surprised if
@v4
didn’t work under node16. Is there a specific reason we selected the soon-to-be obsolete version in this case, or is it just being conservative? cc @curved-manchester-66006
I assume you didn’t do that work in vain, so I guess it is necessary, but it also means pretty soon this CI will fail, so I’m hoping my assumption is wrong.
I also note that https://github.com/pantsbuild/pants/pull/21650 was cherrypicked to 2.23.x, but is not in 2.24.x…