https://pantsbuild.org/ logo
Join Slack
Powered by
Relatedly (thanks for tolerating all my message), ...
# development
b
Relatedly (thanks for tolerating all my message), I'm planning to branch for 2.24.x and switch main over to 2.25.x. Anything urgent that we should consider landing first?
b
It would be nice (if possible) to get this change in: https://github.com/pantsbuild/pants/pull/21551 That fixes a bug in the PBS provider
b
that would be nice, agreed
c
Not exactly what you asked but I'd love to land https://github.com/pantsbuild/pants/pull/21528 right after the branch
👍 1
h
Related: I’ve merged https://github.com/pantsbuild/pants/pull/21561, and it’ll be cherrypicked back to 2.22.x and 2.23.x
If we want to get it in to 2.23.0 then we need to update the release notes. I propose not doing that, but instead getting it out in 2.23.1 (and keeping its release notes in 2.24.x), but am open to alternative ideas
Hmm, actually we need to modify the release notes for 2.23.x anyway, to mention our sponsors (h/t to @curved-television-6568 for noticing that we had promised that). So we’ll need another RC, and so might as well squeeze this bugfix in as well.
❤️ 2
OK, so I will get out another RC after this.
b
As a general principle, I don’t think we need an RC just for release note changes. This is very late for a bug fix (for a non-regression) although that one looks reasonably innocuous
h
I’m not sure if it’s late for a bug fix - bug fixes are why we do RCs?
Granted it’s not a regression, but it is broken
Meanwhile, this is not controversial: https://github.com/pantsbuild/pants/pull/21593 (this is the 2.22 branch rc)
b
Yeah, I guess I just had in my head we're intending to release 2.23, so was assuming any non-critical bug fix should slip (otherwise we'll have constant scope creep/never be ready because there'll always be bug fixes coming in that we could cherry pick)
h
I hear ya. In this case we did have a user whose builds are messed up due to this bug, so that made me lean towards criticality.
Especially since there is no workaround
👍 1
Eeep, looks like the 2.23.x release branch version of docs/notes/2.23.x.md is quite different than the one on main branch
Even before my changes
b
h
Ah yes! so let’s merge that before I attempt my cherrypick
Approved
b
merged, thanks for the ✅
✅ 1
h
Phew, now this picked cleanly: https://github.com/pantsbuild/pants/pull/21597
Thanks for the fixes
2 Views
Open in Slack
PreviousNext
Powered by