https://pantsbuild.org/ logo
Join Slack
Powered by
Anything preventing us from releasing 2.23.0?
# development
h
Anything preventing us from releasing 2.23.0?
🐿️ 1
b
ooh, good call out. I'm MOTW, so I can get this out assuming we agree it's gtg
h
I haven’t heard of any showstoppers
Full disclosure: my interest in this is that I want to cut 2.24.x release branch so I can go to town on the legacy options parser on main…
👍 1
b
looks like there's been a bunch of changes since rc0, so I'll get a rc1 out: https://github.com/pantsbuild/pants/pull/21579
How are we feeling about 2.23.0 now (and cutting 2.24.x)? Anything blocking it?
f
Have we drafted a blog post?
(not a blocker per se but good communication strategy)
h
I see no blockers. @curved-manchester-66006, thoughts?
b
Also not really a blocker, but I note that there's a cherrypick on https://github.com/pantsbuild/pants/commits/2.23.x/ that hasn't seen an rc yet
c
Just mentioning this, as there's not been any reactions on it yet... (not saying it should be a blocker) https://github.com/pantsbuild/pants/issues/21625
c
I am not aware of any blockers, but I am also on a long weekend so I am not super on top of things at the moment. @curved-television-6568 do you happen to know if that is a regression?
b
21625 appears to not be a regression (not in 2.23, anyway)
c
It's a regression in the span of going from 2.22.0.dev2 -> 2.22.0.dev3.
I'll see if I can narrow it down further..
b
(Before you spend time on that, be sure to catch up on the issue. I’ve done some analysis that might save you some effort)
c
ah, thanks. didn't look there 😛
bisecting the dev2->dev3 range now... to get a confirmed commit.
yep, confirmed your suspicion there @broad-processor-92400: https://github.com/pantsbuild/pants/issues/21625#issuecomment-2467632873
👍 1
s
I found a small bug in my pr introduced in 2.23 https://github.com/pantsbuild/pants/pull/21633 It would be nice to have it merged before the release
f
Does it need to be fixed on 
main
?
s
ideally in 2.23, but this doesn't break anything, just the options is half-working
f
my point is the usual development flow is to fix on 
main
and then let the auto-cherry-pick GitHub Action port it back to the prior version
(setting 
needs-cherrypick
label on the PR and the 
2.23.x
milestone)
s
ok, I can open a pr to 
main
rebased the existing pr onto main https://github.com/pantsbuild/pants/pull/21633
Thank you for fast review!
2 Views
Open in Slack
PreviousNext
Powered by