wide-midnight-78598
06/30/2024, 8:55 PMexperimental
means anymore, as we've had the conversation in the past that it should really mean preview
- which to me implies something less "breaky"
Three thoughts/questions:
• Is Terraform stable enough to come out of experimental? I don't use Terraform, so I've got no clue
• Should we have a Terraform tracking ticket where we can keep breaking changes (like changing the "version" specification) whenever we come out of experimental? Make sense to lump breaking changes together
• I don't know if we really have a version naming convention policy, but for me, personally - I like the cases where, if we pull from Github Releases, we use the exact form specified by the tool (e.g. if the tool uses "v1.2.3" we use that, if the tool uses "1.2.3", we use that)careful-address-89803
06/30/2024, 9:10 PMdownload-terraform
-> terraform
• some way of ejecting from pants, so you can run manual steps (some issues have come up for migrating state, for example)
• perf: it's currently really slow because it doesn't cache providers
I'll make a tracking ticket, if others have requirements I'll add themcareful-address-89803
06/30/2024, 9:26 PMtfsec
has both forms in its file path, where the releases are v1.2.3
but the filename includes only 1.2.3
. So we can decide
• these are only coincidentally related (and require both specified)
• the version name should be extracted from the release self.version[1:]
• the release name should be derived from the version v{self.version}
I searched through the codebase for default_version and tried to remove tests
• 9 using v1.2.3
• 26 using 1.2.3
Also, for migrating, it's easy to strip/add the "v", so if we decide to standardise one way we can offer a smooth transition.careful-address-89803
06/30/2024, 9:31 PMwide-midnight-78598
06/30/2024, 10:45 PMThe problem is that🤦♂️has both forms in its file pathtfsec
I'll make a tracking ticket, if others have requirements I'll add them🥳
careful-address-89803
07/01/2024, 1:27 AM