https://pantsbuild.org/ logo
Join Slack
Powered by
_edit: I also wonder if we should change `py_gener...
# development
f
> _edit: I also wonder if we should change 
py_generated_sources
to 
py_generated_sources_in_resolve
(to be released in 2.22) and 
py_hermetic_scripts
to 
py_hermetic_scripts_in_resolve
(released in 2.21) so that these options can be specified per resolve._ Fine by me. I am open to making the options better named or more consistent with each other.
c
cc @proud-dentist-22844 Sorry I see this old thread, but did we land on a decision or take action?
f
Any preference from your use case?
p
I have not taken the time to work on that (and I forgot). I'm on vacation this week, so I won't be able to do anything until next week at the earliest.
The consensus (if there can be a consensus with only @fast-nail-55400 and I) is that more consistency is a good thing™️.
c
Any preference from your use case?
Having it be per-resolve so that it can be encoded in pants.toml and not a flag to remember would be nice.
f
Then I’ll work up a change to make it be per-resolve.
@proud-dentist-22844: Should we land this change on 2.22 before release? (to avoid deprecation cycle for 
py_generated_sources
)
👍 1
➕ 1
For 
--export-py-hermetic-scripts
, it is a default true bool option. So switching to 
--export-py-hermetic-scripts-in-resolve
would mean losing the default behavior if the default empty list of the string list option is used.
Maybe the option should be 
--export-py-nonhermetic-scripts-in-resolve
? That is, the user opts in to non-hermetic scripts in the resolve via the option.
p
Oh. True.
f
https://github.com/pantsbuild/pants/pull/21181 introduces 
--export-py-non-hermetic-scripts-in-resolve
Open in Slack
PreviousNext
Powered by