Does anyone recall why we have jvm code under `src python pa Pants #development

Does anyone recall why we have jvm code under `src...

happy-kitchen-89482

04/09/2024, 9:56 PM

Does anyone recall why we have jvm code under

src/python/pants/jvm/

instead of

src/jvm/

fast-nail-55400

04/09/2024, 10:01 PM

because it is shared by java and scala backends, right?

fast-nail-55400

04/09/2024, 10:02 PM

for example,

src/python/pants/jvm/compile.py

has the definition for

ClasspathEntryRequest

which is critical to the compile workflow for jvm

happy-kitchen-89482

04/09/2024, 10:10 PM

It could still be in

src/jvm

not under

src/python

happy-kitchen-89482

04/09/2024, 10:10 PM

I guess it's because we treat it like a resource for python code (which then compiles it at Pants runtime)

happy-kitchen-89482

04/09/2024, 10:13 PM

which is awesome btw because I can iterate on java code and pants does the right thing just by running it

fast-nail-55400

04/09/2024, 10:24 PM

but it is python rule code

fast-nail-55400

04/09/2024, 10:25 PM

There are some Java source under

src/python/pants/jvm/**

which could be moved over, but most of the files under that directory are Python rule code.

happy-kitchen-89482

04/10/2024, 5:45 PM

Yeah, I am referring to the .java files, naturally

happy-kitchen-89482

04/10/2024, 5:45 PM

I am wondering why we have .java files under

src/python

and not

src/jvm

happy-kitchen-89482

04/10/2024, 5:45 PM

By "jvm code" above I meant "code in java" not "python code for the jvm backend"...

happy-kitchen-89482

04/10/2024, 5:46 PM

should have been more clear

2 Views