Our recent batch of releases (2.19.2, 2.20.0rc3 an...
# development
b
Our recent batch of releases (2.19.2, 2.20.0rc3 and 2.21.0.dev5) are all broken on arm64 macOS: they include x86-64 code for
psutil
, not arm64. https://github.com/pantsbuild/pants/issues/20765 I haven't dug into the cause other than what's in that issue. As noted in a comment, I've marked 2.19.1 as the latest (stable) release and added a note to the broken releases.
Done some investigation in https://github.com/pantsbuild/pants/issues/20765#issuecomment-2042045387, but ran out of time for now
šŸ‘€ 1
2.19.2 (etc.) release brokenness looks to be a rosetta thing: https://github.com/pantsbuild/pants/issues/20765#issuecomment-2043814681 I think someone who can poke at the machine live via ssh (and/or knows more about self-hosted runners) might need to take over the investigation here.
w
The self-hosted runner has Rosetta installed? By default?
b
yes
I've prepped an ad-hoc dev release to see whether the "upgrade psutil" workaround does actually paper over the arm64 macOS release problems. If someone has a moment to review, that'd be great, thanks: https://github.com/pantsbuild/pants/pull/20775
g
I would if I could šŸ˜‰
w
Easiest review ever
Done
b
It looks like the psutil workaround does paper over the arm64 macOS release problems in the 2.21.0.dev6 release there, so I've now prepped: • 2.19: cherrypick + rc release prep • 2.20: cherrypick + rc release prep Could someone review? Once those are in and validated, I think we should do a 2.19.3 stable release (essentially identical to 2.19.2, except working on arm64 macOS) and then can probably get the 2.20.0 stable release out too.
w
If no one else can sooner I'll be available probably in about 30-45m to review
šŸ‘ 1
Done. Also, speaking of automation - I wonder if cherry picks and release bumps can be auto-approved if submitted by a maintainer
b
Thanks for the review I'm not sure, sometimes the cherry picks have non-trivial changes from the parent (e.g. this case, I stripped out the ijson bump and just had the psutil one)
šŸ‘ 1
w
thanks a lot Huon. I haven't forgotten about the release manager changes, just had a crazy week this week: planning to do something about it next week.
b
all good, individual releases are easy with Josh's changes; just seems like it'd be good for the health of the project to spread the knowledge/decision making around a bit more šŸ™‚
šŸ‘ 1