It looks like there's been two fixes to 2.18.x sin...
# development
b
It looks like there's been two fixes to 2.18.x since 2.18.2 was released a month ago: https://github.com/pantsbuild/pants/compare/release_2.18.2...2.18.x Should we do an 2.18.3rc0, and then 2.18.3 a bit later and then call 2.18.x finished?
c
sounds good to me. I wonder how much consideration went into that backported fix for go to 2.18.x as well.. (if it's required/asked for)?
p
I didn’t backport one of my fixes to 2.18.x because I was told we weren’t going to do any more 2.18.x releases… If that’s not the case, I have some fixes I could make … 🙂
b
Ah yes: https://pantsbuild.slack.com/archives/C0D7TNJHL/p1705116645008889 if only I could remember prior discussions. So we could: 1. Close the milestone/branch now and leave those fixes unreleased in 2.18.x 2. release with no more back ports 3. release with more back ports I’m MOTW next week and I’m happy to do 3: an RC early in the week with whatever is backported by then and stable release later (assuming RC is working). Sound good?
p
Here are the 3 cherry-pick PRs for the bugfixes I would like to see in 2.18.x 🙂 Thanks! https://github.com/pantsbuild/pants/pull/20599 (needs a review since I had to manually fix a whitespace merge conflict) merged https://github.com/pantsbuild/pants/pull/20601 (I reviewed and enabled auto merge) merged https://github.com/pantsbuild/pants/pull/20602 (I reviewed and enabled auto merge) merged
👍 1
Excellent. Those 3 are merged. With those, I will have a version of pants that has the fixes and has both python-based and rust-based python dep inference. That will give me a nice upgrade path. 🙂
🎉 1
🙌 1
b
I'm MOTW this week, and I'm intending to get a 2.18.3 release out. I'll prep an 2.18.3rc0 soon (in the next 24 hours or so), and then try to do the stable one by the end of the week. We'd previously half-decided to finish at 2.18.2, but there's a few fixes that had landed, and some extras we've slotted in that will ease upgrades. If there's anything else you'd like to get in, please let me know and/or cherry-pick it yourself ASAP, so that the RC can go out soon.
👍 1
2.18.3rc0 (hopefully the only RC) is ready at https://github.com/pantsbuild/pants/pull/20612 Let me know soon if you've thought of any more bugfixes that would be handy for the 2.18 release series; if I don't hear otherwise I'll merge that later today.
1