As per a discussion with <@U03P5521VBJ> on <#C046T...
# development
f
As per a discussion with @broad-processor-92400 on #general, I am making a minor patch to add the
build_full_path
to the
docker
comfiguration. • as a first check - running the tests (docker in docker, vscode devcontainer) failss 3x tests - is this expected or is it my local (hastily setup vscode/devcontainer)
My devcontainer config was / is
Copy code
{
	"name": "Python 3",
	"image": "<http://mcr.microsoft.com/devcontainers/python:1-3.9-bookworm|mcr.microsoft.com/devcontainers/python:1-3.9-bookworm>",
	"features": {
		"<http://ghcr.io/devcontainers/features/rust:1|ghcr.io/devcontainers/features/rust:1>": {},
		"<http://ghcr.io/devcontainers/features/docker-in-docker:2|ghcr.io/devcontainers/features/docker-in-docker:2>": {}
	},
	"postCreateCommand": "apt update && apt-get install -y protobuf-compiler; curl --proto '=https' --tlsv1.2 -fsSL <https://static.pantsbuild.org/setup/get-pants.sh> | bash; pants --version",
}
b
What were the failures? They look to be the tests that actually run/interact with docker, so I suspect it is something about the devcontainer. We'll see what CI says for real
CI says oops, looking at the wrong PR
f
@broad-processor-92400 yea I think so too. I’ll re run tomorrow