Would appreciate some eyeballs on <https://github....
# development
h
Would appreciate some eyeballs on https://github.com/pantsbuild/pants/pull/20505 . There may be unintended consequences I'm not seeing.
c
If you have a.py and a_test.py and you delete a.py then should a_test.py be flagged as transitively changed? It doesn't look like that's currently the case either, though
h
How would that work?
Even today
OK, completely changed that PR to be much narrower. It solves the immediate issue without impacting the wider one (which is complicated) at all.
c
That was the problem-case I thought up. But I tried it out and found that it didn't happen on the current release either. So I guess that isn't actually a problem. And you right, IDK how to implement that, short of identifying targets on both the current branch and the changed-since branch and doing the diff. Which sounds like it would be a lot of edge cases.
h
You'd have to roll back the git state to look at the BUILD file state in the past
Which is a thing we might want to do at some point I suppose
but it is not easy