https://pantsbuild.org/ logo
Join Slack
Powered by
I assume we should not be listing 2.17 and 2.16 as...
# development
f
I assume we should not be listing 2.17 and 2.16 as "prerelease" in the versions drop-down on the docs site?
b
Cc @gorgeous-winter-99296
g
Ugh, the checked in data for those versions is from 2.17.1rc3, for example. So technically it's right, the last version in that series is a pre-release.
b
Feel free to just edit the JSON for all versions we aren't going to sync. 🤷‍♂️
Or we could manually dump the help for the released versions
g
I'll have a look tomorrow. I'm not sure what is semantically correct... maybe the pre-release check should be for 
xx.yy.0(.dev|a|b|rc)zz
b
Eh?
How's that different than what we do today?
b
The 
0
is hard coded, I imagine
g
Yeah, right now we just check for the trailing specifier, but let the patch version be anything
b
Potentially we shouldn't overwrite 2.x.0 stable docs with 2.x.1 prerelease docs at all, though? Only 2.x.1 stable docs
Additionally, shouldn't those releases have the docs for latest release (which would be a stable 2.17.1 or 2.16.2 or whatever those branches are up to)? rather than a "random" RC?
b
The 0 is hard coded, I imagine
Ah yes. Sorry that wasn't immediately obvious, but now it makes sense
Potentially we shouldn't overwrite 2.x.0 stable docs with 2.x.1 prerelease docs at all, though? Only 2.x.1 stable docs
That makes sense to me, I think
I'd approve that PR
h
Yeah, once we release we should only publish stable docs for that release branch
b
g
7 Views
Open in Slack
PreviousNext
Powered by