I need AWS configured in my `docker_environment`, ...
# developmentb
bitter-ability-32190
12/19/2023, 4:57 PMI need AWS configured in my
docker_environmentdocker_environemntbitter-ability-32190
12/19/2023, 4:57 PMCC @fast-nail-55400 @witty-crayon-22786
f
fast-nail-55400
12/19/2023, 7:18 PMYes probably. Moreover, there is ample room for improvement in how we allow the container to be configured.
b
bitter-ability-32190
12/19/2023, 8:28 PMHow would this get wired up? I suspect it should be a field on the
docker_environment<http://docker.rs|docker.rs>ProcessExecutionStrategyimagef
fast-nail-55400
12/19/2023, 9:05 PMthere is
ProcessExecutionStrategy::Dockerfast-nail-55400
12/19/2023, 9:06 PMswitch that enum variant to be a struct variant
b
bitter-ability-32190
12/19/2023, 9:13 PMYou think that's the right place? It certainly ticks the boxes but it feels weird to me.
Although I'm an outsider to this part of the codebase
f
fast-nail-55400
12/19/2023, 9:14 PMfast-nail-55400
12/19/2023, 9:15 PMYou basically will be marshallling the Docker-specific fields onto
ProcessExecutionEnvironmentProcessfast-nail-55400
12/19/2023, 9:16 PMOn the Rust side, it is unmarshalled into a
ProcessExecutionStrategy::Dockerb
bitter-ability-32190
12/19/2023, 9:17 PMYeah, I think I grokked all the pieces at play just wasn't sure where mine fit, since the strategy was most convenient but also was worried I was shoe-horning
f
fast-nail-55400
12/19/2023, 10:39 PMI don't believe it is shoe-horning. Just extending the existing way we plumb the image name through the Python->Rust transition.
b
bitter-ability-32190
12/19/2023, 10:41 PMCool. I'll give it a shot tomorrow
bitter-ability-32190
12/20/2023, 6:58 PMHuh, getting something together was suprisingly easy...
bitter-ability-32190
12/20/2023, 7:22 PM2 Views