https://pantsbuild.org/ logo
Join Slack
Powered by
I'm on release duty this week. - Are we still wai...
# development
b
I'm on release duty this week. • Are we still waiting on anything for 2.18.2rc0? ◦ @curved-television-6568 found https://github.com/pantsbuild/pants/pull/20230 is that one good to go or are we still waiting for feedback? ▪︎ @fast-nail-55400 @happy-kitchen-89482? • I assume 
2.19.0rc2
is good to go? ◦ https://github.com/pantsbuild/pants/milestone/62 is empty
h
#20230 is good to go from my side of things
b
If 20230 is merging soon, 2.19.0rc2 could wait for it (since it’ll be cherry-picked to 2.19.x also)
b
That's a very good point
I'll probably start releases tomorrow maybe? Today is now completely shot for me. Tomorrow is TBD. This was poorly timed 😂
h
I usually do them on the weekend
b
There's time for me yet
c
thanks for getting 20230 in. could we also get https://github.com/pantsbuild/pants/pull/20276 in?
b
Does that need to be tagged for cherry picking?
c
oh, yes, it should. done
b
I'll wait then
c
Someone with merge permissions needs to merge it
✅ 1
c
picked how far back? workerpants made me aware it was not added to a milestone so the autopick was a dud.
b
(when that answer is decided and the PR is tagged you can rerun the cherry pick action on the PR manually in GitHub UI)
c
yep, gotcha. thanks.
I’m about to head out for tonight, so won’t check until tomorrow, most likely
b
That's ok I'm just resigning to doing releases Monday. 😅
c
I gave it the milestone of 2.18.x, since I think that's when I introduced that. I think someone's going to have to boop the cherry-picker
h
Hmm, the CI for both cherrypicks of of #20230 is failing consistently on the ARM shard
I rebooted that machine but it didn't help
Oh, hmm, maybe it did help on the 2.18.x branch cherrypick, at any rate that one passed
🎉 1
and is now merged
(the error was unrelated to the content of the change, looked like bad state on the runner)
OK, the 2.19.x cherrypick is in too
🎉 1
5 Views
Open in Slack
PreviousNext
Powered by