If someone has a moment to take a look at the cher...
# developmentb
broad-processor-92400
12/11/2023, 6:18 PMIf someone has a moment to take a look at the cherry-pick https://github.com/pantsbuild/pants/pull/20281, that’d be appreciated.
broad-processor-92400
12/12/2023, 10:35 PMGentle re-request for a review of https://github.com/pantsbuild/pants/pull/20281; thanks!
✅ 1
g
gorgeous-winter-99296
12/12/2023, 10:36 PMIs this a straight cherry-pick or anything that needs reviewing?
b
broad-processor-92400
12/12/2023, 10:36 PMI had to resolve some merge conflicts in import statements in real code, and then update tests to provide some additional mock data, compared to the original PR
g
gorgeous-winter-99296
12/12/2023, 10:37 PMAck, looking
gorgeous-winter-99296
12/12/2023, 10:40 PMApproved! Didn't look too deep as it's a cherry-pick, but checked the imports + tests a bit at least.
b
broad-processor-92400
12/12/2023, 10:40 PMthanks
6 Views