IIRC running, e.g., isort as a check-only linter n...
# development
h
IIRC running, e.g., isort as a check-only linter now runs it as a formatter under the covers and then discards the edits in the sandbox? What happens with linters that have useful output in check-only mode but not in change-the-file mode? (isort is such an example) We now lose that output, I think?
b
Yes
b
I think the
ruff
backend has separate behaviour for fix vs. lint?
h
so... is this a problem? I forget if we discussed this when making that otherwise-nice change.
b
I'm not sure I understand the question... but in my brief experiments with ruff, I was getting useful output from
lint
, not just "this file would be changed" (or similar)
h
I'm seeing this specifically for isort, which outputs the diff in check mode, and just quietly applies the diff in modify mode
b
That not surprising. Are you suggesting something or just reporting something?
h
Wondering if this is a problem - we decided to re-implement checks as "format and discard", which generally seems more streamlined, but I don't remember if we considered this angle.
That users of a tool will expect output that we are now not providing, we're just saying "here are files that would have changed", not any info about the nature of the change
b
Yes, it's likely in the original proposal
If you want to propose a way for us to output the diff, we could do that unilaterally
But otherwise, the fix is to run fix (pun intended)