<@U01PZK60W2F> Just a gentle reminder on this one ...
# developmentn
nutritious-hair-72580
11/13/2023, 9:21 AM@curved-television-6568 Just a gentle reminder on this one - https://github.com/pantsbuild/pants/pull/20154#pullrequestreview-1721159959
🙏 1
c
curved-television-6568
11/13/2023, 3:20 PMthank you. I’m happy with the UX of this.. was about to look closer at the type hint thing, but we don’t have to wait landing this first, can always circle back in case I find something useful in that regard.
👍 1
n
nutritious-hair-72580
11/14/2023, 2:57 PMThanks. Can we add this to 2.19, as otherwise the changes added earlier to support caching (
--cache-to--cache-frompublishc
curved-television-6568
11/14/2023, 3:13 PMSounds good to me, even though we just cut the alpha.
cc @witty-crayon-22786 @broad-processor-92400 @bitter-ability-32190 @happy-kitchen-89482 thoughts?
h
happy-kitchen-89482
11/14/2023, 3:52 PMI think that's OK to cherrypick
b
broad-processor-92400
11/15/2023, 5:26 AMI've done the motions to cherry pick to 2.19. Should we cherry-pick to 2.18 too? I guess we could try to get a few small things in for a 2.18.1rc0 over the next few days, and then maybe 2.18.1 next week?
https://pantsbuild.slack.com/archives/C046T6T9U/p1700020541207749?thread_ts=1700018839.824209&cid=C046T6T9U
🙏 1
c
curved-television-6568
11/15/2023, 5:30 AMthat would be great, yes. As the feature addresses a shortcoming for options introduced in 2.18..
n
nutritious-hair-72580
11/15/2023, 10:20 AMIIRC the cache options were only added in 2.19 - I added some other options in 2.18. So this should only be cherry-picked to 2.19.
👍 2
c
curved-television-6568
11/15/2023, 6:34 PMyes, thank you @nutritious-hair-72580, I must’ve got this confused with something else.
b
broad-processor-92400
11/15/2023, 9:14 PMah, cool.
https://github.com/pantsbuild/pants/pull/20185 is merged to 2.19. Thanks Andreas!
🙏 1
2 Views