I have a PR that reformats some help strings and f...
# development
p
I have a PR that reformats some help strings and fixes a typo in one help text string. I used
category:documentation
, but I can also see that being
category:bugfix
or
category:internal
. What category makes the most sense? edit: oh. the doc category is problematic because it doesn't run the tests, so if any test happened to check one of these help texts, they might break. Hmm. I guess
category:bugfix
?
1
h
I'd probably say internal. most of the changes aren't user-facing. we want the changelog to have changes that users benefit being aware from changelog != git developer log
👍 1
p
sounds good
b
(BTW, I believe
category:documentation
doesn’t affect CI’s testing: that test filtering is done based on which filepaths are changed, and the label is for changelog generation only.)
1
p
Huh. You're right. I assumed that it went really quickly because it skipped the tests... I forgot that pants has this awesome fine-grained cache 😛