I know the team has been busy these last days prep...
# development
w
I know the team has been busy these last days preparing the release of 2.18, wondering if there could room for making this bugfix into the final release: https://github.com/pantsbuild/pants/pull/20157
b
Thanks for the fix! Is this a regression from 2.17.0?
w
I believe it's older, the rule to support Scala 3 and resolve its artifacts was added in December last year, just it seems it wasn't widely adopted in the backend: https://github.com/pantsbuild/pants/commit/19f7351278d20518acdfb4e525fbb73a45eda9fe
b
Ah, given it's older, my opinion would be that we leave it for 2.19.0, and maybe 2.18.1 (i.e. cherry pick after 2.18.0 is released). That is, since we're so close to 2.18.0, we should be trying to keep things stable and only fix critical issues like regressions-from-last-stable, or else we'll never ship it (always "one more bug fix"). That said, I imagine others might differ in opinion
w
cool for me leaving it for 2.19, I mostly work with Pants from sources. just that I thought that having such a tiny impact I may be possible to include in 2.18
c
I agree with @broad-processor-92400 that if we could hold it for a little bit to ship 2.18.0, then we can follow up without much delay a 2.18.1 if we want to, which will be quicker than having to wait for it to land in 2.19.0.
w
sounds fair to me, I'll remove the cherry pick label and leave it for 2.18.1
thinking twice, I'll leave the label and just wait for the merge until 2.18.0 is released
👍 3
b
Sounds good, thanks for checking!