Wondering about this... I've helped a few people w...
# developmentg
gorgeous-winter-99296
10/31/2023, 8:16 PMWondering about this... I've helped a few people with this before, messed it up myself, and it leads to weirdness like this:
Copy code
@rule(desc="Noop package", level=LogLevel.DEBUG)
async def package_nothing(field_set: MirrorImageFieldSet) -> BuiltPackage:
return BuiltPackage(
digest=EMPTY_DIGEST,
artifacts=tuple(),
)gorgeous-winter-99296
10/31/2023, 8:23 PMIt seems intuitive that you'd need to package before you publish, when we talk about "classic" artifacts. When e.g. talking about a Kubernetes manifest, a docker image, etc etc, it seems quite roundabout. My above example is a mirroring plugin for my oci backend, where I explicitly do not want to package it - just download and immediately upload.
gorgeous-winter-99296
10/31/2023, 8:23 PMSo I'm wondering whether we could run the package command if existing and otherwise just continue
gorgeous-winter-99296
10/31/2023, 8:24 PMOr maybe even a flag on the request/fieldset to opt-out
c
curved-television-6568
10/31/2023, 8:24 PMI have a plugin for that… planning on upstreaming it, but won’t be until early 2024
curved-television-6568
10/31/2023, 8:24 PMbut yea, was going to suggest that we probably want to have a flag on the publish field set so we can influence this:
https://github.com/pantsbuild/pants/blob/57a3b7c38ed370a7c863a79fe320015fbe00c9eb/src/python/pants/core/goals/publish.py#L210-L213
g
gorgeous-winter-99296
10/31/2023, 8:25 PMA plugin for what? 😄
c
curved-television-6568
10/31/2023, 8:26 PMsorry, prob not exactly the same, but sounded very familiar.. a plugin that basically does
Copy code
docker pull x
docker tag x y
docker push yg
gorgeous-winter-99296
10/31/2023, 8:27 PMAh, yeah. That's what I do pretty much, but in a no-docker world. 😉
👍 1
gorgeous-winter-99296
10/31/2023, 8:27 PMAnyways, was mostly an example of where I don't want a package goal but have to have one.
c
curved-television-6568
10/31/2023, 8:28 PMI don’t recall having a dummy package step in there.. but I may just have memory glitches..
curved-television-6568
10/31/2023, 8:28 PMI’m currently in no access to that code, hence why the upstreaming won’t happen atm