I'm going to (try to) do 4 releases this week: - 2...
# development
b
I'm going to (try to) do 4 releases this week: • 2.19.0.dev2 • 2.18.0rc2 • 2.17.1rc1 • 2.16.1rc3
2.19.0.dev2 prep, if someone has a moment to review: https://github.com/pantsbuild/pants/pull/19983
🚢 1
h
Do we no longer manually create the release notes? I forgot where we landed on that
b
Yeah, the release notes are currently only placed into the GH release, e.g. https://github.com/pantsbuild/pants/releases/tag/release_2.18.0rc2
(at least, for 2.18+, I think the 2.16 and 2.17 branches still write to disk. I haven't had time to finish the prep for them yet)
c
yea, it makes reviewing the prep a bit blindfolded I find.. last one I reviewed, I went to the release branch history to get a sense of what was being released.
b
They could also be placed on the PR description
h
Woohoo! The less work the better 🙂
b
....I just realized. Why do you wanna see the changelog entries? Does it change anything about your approval?
b
2.16.1rc3 release prep: https://github.com/pantsbuild/pants/pull/19985 2.17.1rc1 release prep: https://github.com/pantsbuild/pants/pull/19989 Ready for review whenever
It looks like the 2.17 release build https://github.com/pantsbuild/pants/actions/runs/6426486346 failed with errors like:
Copy code
ERROR: pantsbuild.pants-2.17.1rc1-cp37-cp37m-linux_aarch64.whl is not a supported wheel on this platform.
I'm guessing it's probably related to https://github.com/pantsbuild/pants/commit/c78945b5bb4e167b70a472b24ed49e1a2aa307fe
The 2.16 release seems to have built wheels etc. successfully 🎉 To finish it, I'll either need: 1. PyPI access myself (I'm
huon
) 2. sometime else to run
./build-support/bin/release.sh publish
in step 4 https://github.com/pantsbuild/pants/blob/a91cfdb777c0a6ac14bed33219369516127a2e82/docs/markdown/Contributions/releases/release-process.md#ste[…]sesh
h
Sent you invites to PyPI access
👍 1
b
Thanks, I see and accepted
Phew! 2.16.1rc3 successfully published (along with 2.18.0rc2 and 2.19.0.dev2). The 2.18+ release process is much easier on the releaser than the 2.16 one! I've well and truly used up my volunteering time today, so I'm not going to get a chance to look at the 2.17.1rc1 build failures above; hopefully someone else can?
b
Re: 2.17, that commit went in to try and fix that exact error. So 🫠
👍 1
Also I'm glad you enjoyed 2.18+ release process. We're so close 👍
👍 2
c
It sure is stirring up some intermediary turbulence, but so worth it; thank you Josh!
b
Yeah, I think there's be little turbulence if we just made the changes on main and let it trickle through the releases, but my hope is that we get to the future sooner
Also why I'm trying to absorb the turbulence if I can. It just too bad you write tests for GitHub actions easily
c
yea, I’m happy to take some turbulence to shorten the gap.
b
I also think we'd be home free if it wasn't for the dot releases
h
Yeah, and these should be the last 2.16.x and 2.17.x releases, one hopes
b
Do we do .2 s?
h
If we have to, for a bugfix, but we don't commit to it
we'd rather people upgraded to the next minor
b
Yeah fully agreed on tolerating turbulence. 👍 Maybe next release of 2.16 can be 2.16.1 final? My memory of the milestone is there’s nothing major outstanding (currently on phone so cannot check easily) And similarly for 2.17.1? (if someone can resolve the release issues, I won’t have time to look this weekend, sorry) There’s some seemingly major regressions in the 2.17 milestone, but I’m not sure there’s any progress there, and we can always do a 2.17.2 later if helpful (or get these hypothetical fixes out in 2.18.0/.1 instead). Maybe a quick discussion of targets/timelines for the next few patch and minor releases and any blockers would be a good one for the monthly?
h
Yep, I think those rcs can be the last ones
b
When 2.17 is done in earnest, we switch to the simpler releases from here out
Although 2.16 is the last "manual" release series
b
I filed https://github.com/pantsbuild/pants/issues/19996 with the issue blocking 2.17
w
thanks. as mentioned in the meeting, once we actually have a
2.17.1rcX
release candidate, we’ll want to ping folks who had blocking issues with the
2.17.0
release, and ensure that they’ve tried this candidate… otherwise we’ll be be likely to need more stable releases of
2.17.x
b
I'm gonna try to look at my GitHub release issues this afternoon. If not today, tomorrow
❤️ 2
b
Thanks. Do we have suspects for what if anything would’ve fixed the 2.17 issues? AIUI there’s been no explicit work towards many of them and they seem to be intermittent rather than reliably reproducible…
b
Can you be more specific? I'm not tracking
b
Sorry, on phone, but the issues listed in the 2.17 milestone include remote backtracking, tar concurrency and something about “too many open files”