Have we discussed the release failures for 2.17.x ...
# developmentb
bitter-ability-32190
10/02/2023, 6:38 PMHave we discussed the release failures for 2.17.x and 2.16.x yet?
ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'OpenSSL 1.0.2k-fips 26 Jan 2017'. See: https://github.com/urllib3/urllib3/issues/2168https://github.com/pantsbuild/pants/actions/runs/6286002410/job/17070047264 https://github.com/pantsbuild/pants/actions/runs/6286401038/job/17069772062
bitter-ability-32190
10/02/2023, 6:44 PMLooks like it's an invocation of
twinebitter-ability-32190
10/02/2023, 7:39 PMLet's see if downgrading
urllib3bitter-ability-32190
10/02/2023, 8:42 PMOK confirming that downgrading
urllib3bitter-ability-32190
10/02/2023, 8:42 PMWill make PRs shortly
bitter-ability-32190
10/02/2023, 8:42 PM(unless someone else has a suggestions regarding upgrading something transient in the container to be compatible)
bitter-ability-32190
10/03/2023, 1:38 PMI think this has to do with Python 3.7, since this doesn't error on 2.18+, and doesn't error for Py39 in these releases
bitter-ability-32190
10/03/2023, 2:15 PMWell I guessed the only real thing that changed was the
manylinux:latest2.17.0bitter-ability-32190
10/03/2023, 2:16 PMI'll make that PR
b
broad-processor-92400
10/04/2023, 10:09 AMThanks for making the fixes.
Does this mean the releases that were failing have now succeeded? Or should I be cutting new releases? (2.16.1rc1 and 2.17.1rc1, I think?)
broad-processor-92400
10/04/2023, 10:29 AMAh, no, next would be 2.16.1.rc3
b
bitter-ability-32190
10/04/2023, 12:13 PMI'm not sure, honestly on 2.16, because I don't see tags for rc1 or rc2
bitter-ability-32190
10/04/2023, 12:13 PM2.17 yes do the next one
bitter-ability-32190
10/04/2023, 12:23 PMI can probably make the 2.16 releases exist, so don't do rc3 unless there's changes
c
curved-television-6568
10/04/2023, 5:39 PMwhere are we with the 2.16 release now? I feel bad for just abandoning it, so if there’s something needs to be done with it, I can dig into it.
b
bitter-ability-32190
10/04/2023, 5:51 PMCan you push the tags? I think that's all that's needed
👍 1
c
curved-television-6568
10/04/2023, 6:03 PMI think we can ignore 2.16.1rc1.. the rc2 is mostly a retry of a failed release of rc1
curved-television-6568
10/04/2023, 6:03 PMpushed the rc2 tag now.
b
bitter-ability-32190
10/04/2023, 6:04 PMI mean no harm in tagging? But okie dokie. I'll try and get rc2 tonight if I can
👍 1
c
curved-television-6568
10/04/2023, 6:04 PMsure, I’ll tag it just to plug the tag-hole…
curved-television-6568
10/04/2023, 6:05 PMdone