FYI. Now that release prep is always done on the b...
# developmentb
bitter-ability-32190
09/21/2023, 2:01 AMFYI. Now that release prep is always done on the branch itself. I'm turning on branch protection for every release branch 🙂
Thanks for playing ❤️
❤️ 2
bitter-ability-32190
09/21/2023, 2:01 AMFYI @witty-crayon-22786. No more two-PRs 😛 Finally.
bitter-ability-32190
09/21/2023, 2:08 AMFor posterity I implemented this as a ruleset, so I could enforce one setting across
mainc
curved-television-6568
09/21/2023, 2:08 AMcould wait until 2.16 and 2.17 are done, perhaps?
b
bitter-ability-32190
09/21/2023, 2:09 AMNo, you should bump the version in that PR. This is now called out on the docs with my two latest PRs 😛
https://github.com/pantsbuild/pants/pull/19896
https://github.com/pantsbuild/pants/pull/19895
c
curved-television-6568
09/21/2023, 2:10 AMand have them auto-picked to the release branches then?
curved-television-6568
09/21/2023, 2:10 AMbut wait, mr PRs are for
maincurved-television-6568
09/21/2023, 2:11 AMdon't want to bump VERSION there
b
bitter-ability-32190
09/21/2023, 2:11 AMOh hmm
bitter-ability-32190
09/21/2023, 2:11 AMI totally missed that
bitter-ability-32190
09/21/2023, 2:12 AMDo we really need those on
mainc
curved-television-6568
09/21/2023, 2:12 AMmaybe not any more... but feels weird to stop mid release branch.
b
bitter-ability-32190
09/21/2023, 2:13 AMThe https://www.pantsbuild.org/docs/changelog page could just point to the release branch. And we can always recreate form the releases.
c
curved-television-6568
09/21/2023, 2:13 AMfeels better to keep doing it for 2.17 at least, then I guess we could not for 2.18
b
bitter-ability-32190
09/21/2023, 2:13 AMmaybe not any more... but feels weird to stop mid release branch.True. OK
bitter-ability-32190
09/21/2023, 2:13 AM(We already don't for 2.18)
c
curved-television-6568
09/21/2023, 2:13 AMyea
curved-television-6568
09/21/2023, 2:13 AMok
b
bitter-ability-32190
09/21/2023, 2:13 AMOK so I disabled https://github.com/pantsbuild/pants/settings/rules/96431
Luckily it still sticks around
c
curved-television-6568
09/21/2023, 2:14 AMcool, guess we can just enable it again once we're done with the <=2.17 releases
b
bitter-ability-32190
09/21/2023, 2:14 AMyee
c
curved-television-6568
09/21/2023, 2:16 AMabout to hit bed, will pick and run the final step for those releases tomorrow.