https://pantsbuild.org/ logo
Join Slack
Powered by
I'm getting CI failures about the github release w...
# development
b
I'm getting CI failures about the github release workflow, but both re-running it and running iwth 
--check
work on my machine: https://github.com/pantsbuild/pants/actions/runs/6252314069/job/16975364123?pr=19868
✅ 1
w
seeing if i repro
b
🙏 It also may be moot if anyone disagrees with the approach of these removed lines: https://github.com/pantsbuild/pants/pull/19868/files#diff-cf0d6e4a1d2ee4ecb8a95bee22e8002db74b268cca773f5397dbdfc42d3593d3
w
i don’t repro 😬
er, sorry: i repro not reproing what CI is showing
b
pants.ci.toml
doesn't seem like it'd repro either
(unrelated but interesting, the default github runner has 
profile = "minimal"
for 
rustup
)
I added some 
difflib
for good measure
Copy code
Error: Generated path mismatched: .github/workflows/release.yaml
To re-generate, run: `./pants run src/python/pants_release/generate_github_workflows.py`

Diff:
--- actual
+++ expected
@@ -361,6 +361,8 @@
       with:
         repo-token: ${{ secrets.GITHUB_TOKEN }}
         version: 23.x
+    - name: Set rustup profile
+      run: rustup set profile default
     - name: Cache Rust toolchain
       uses: actions/cache@v3
       with:
What?!
w
... different versions of toml?
b
Thats just comparing the yaml files
w
er… s/toml/yaml/
b
But its not like the keys are re-ordered or anything. One side has the mapping and the other doesnt 😱
w
but… hm. a sort order difference would exhibit as the lines moving.
coke
b
The line numbers also aren't what I'd expect...
Copy code
@@ -361,6 +361,8 @@
This looks like it's for line 188.
Which is for 
build_wheels_macos10
...that might be a bigass clue. 
git merge main
and I'll wait
that was it
2 Views
Open in Slack
PreviousNext
Powered by