If someone is looking for a relatively easy issue ...
# developmenth
happy-kitchen-89482
09/17/2023, 8:44 AMIf someone is looking for a relatively easy issue to work on, take a look at https://github.com/pantsbuild/pants/issues/3423, our oldest open issue!
l
late-advantage-75311
09/17/2023, 11:21 AMI would love to do it, can you assign it to me? we should have a pr tomorrow.
š 1
h
happy-kitchen-89482
09/17/2023, 12:13 PMWhat's your GH username?
l
late-advantage-75311
09/17/2023, 1:25 PMgauthamnair
h
happy-kitchen-89482
09/17/2023, 1:38 PMAh, can't assign to people who aren't members of the github team (so Contributors or Maintainers), but never mind, we'll know it's yours!
happy-kitchen-89482
09/17/2023, 1:38 PMAnd this is the road to becoming a Contributor ... š
š 1
l
late-advantage-75311
09/19/2023, 12:17 AMThe PR is there as a WIP but what has turned into a big head-scratcher is why I can't get it to work for the python repl (fine for ipython). Debugging through the pex startup for the python shell repl which has been eye opening. Will ask for some assistance tomorrow if the time spent starts to feel fruitless.
late-advantage-75311
09/19/2023, 10:35 AMSo turns out it wasn't for nothing - there are a couple of issues with at least the version of pex we are using that complicate passing arguments to an interactive python repl. https://github.com/pantsbuild/pants/pull/19858#issuecomment-1725241138 . I'll look into those on the pex side, like whether they have been reported already (likely) and possibly resolved. But I am wondering about de-scoping the pants-side issue to just ipython (which just works and was the original user's question).
late-advantage-75311
09/19/2023, 3:15 PMFiled the pex issues with details:
ā¢ https://github.com/pantsbuild/pex/issues/2248
ā¢ https://github.com/pantsbuild/pex/issues/2249
late-advantage-75311
09/19/2023, 7:19 PMI've left a comment on the original issue asking for feedback: https://github.com/pantsbuild/pants/issues/3423#issuecomment-1726338868 . If de-scoped as I suggest there we could close this oldest issue soon.
2 Views