https://pantsbuild.org/ logo
Join Slack
Powered by
I’ll be running four releases during the weekend: ...
# development
c
I’ll be running four releases during the weekend: 
2.19.0.dev0
, 
2.18.0rc0
, 
2.17.1rc0
and 
2.16.1rc1
b
2.19/2.18 you can run the release script from 
main
. 
2.17
and back you have to do it on the branch. LMK if you hit hiccups
c
cool, will do
@happy-kitchen-89482 it looked like you had begun a 2.19.0.dev0 two weeks ago, that wasn’t finished.. I force pushed over your old branch (the 
automation/release/..
one) fyi
👍 1
@bitter-ability-32190 got a few hiccups so far ; 1) I had to run the release script using 
PANTS_CONCURRENT=True
or it failed, 2) the ^^, my branch was pushed to my fork, but the PR was opened using the pre-existing branch from Benjy 😜
I resolved 2) by force pushing to the pants repo, replacing Benjy’s branch with mine.
Ah, and when there was no release automation branch in upstream, it failed to open the PR
Copy code
Writing objects: 100% (366/366), 72.45 KiB | 9.06 MiB/s, done.
Total 366 (delta 253), reused 224 (delta 123), pack-reused 0
remote: Resolving deltas: 100% (253/253), completed with 107 local objects.
remote:
remote: Create a pull request for 'automation/release/2.18.0rc0' on GitHub by visiting:
remote:      <https://github.com/kaos/pants/pull/new/automation/release/2.18.0rc0>
remote:
To <https://github.com/kaos/pants.git>
 * [new branch]            HEAD -> automation/release/2.18.0rc0
Traceback (most recent call last):
  File "/private/var/folders/y2/6t5bbk554wv5h6w_qlgpcpnm0000gr/T/pants-sandbox-CBBpeH/./.cache/pex_root/venvs/3393ad85596517d56a5114519c03d9d3b0b8a914/a21ebad05b913452b05ad0fa71c258e8abead087/pex", line 274, in <module>
    runpy.run_module(module_name, run_name="__main__", alter_sys=True)
  File "/Users/andreas.stenius/.pyenv/versions/3.9.13/lib/python3.9/runpy.py", line 225, in run_module
    return _run_module_code(code, init_globals, run_name, mod_spec)
  File "/Users/andreas.stenius/.pyenv/versions/3.9.13/lib/python3.9/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/Users/andreas.stenius/.pyenv/versions/3.9.13/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/private/var/folders/y2/6t5bbk554wv5h6w_qlgpcpnm0000gr/T/pants-sandbox-CBBpeH/src/python/pants_release/start_release.py", line 137, in <module>
    main()
  File "/private/var/folders/y2/6t5bbk554wv5h6w_qlgpcpnm0000gr/T/pants-sandbox-CBBpeH/src/python/pants_release/start_release.py", line 133, in main
    commit_and_pr(gh_repo, release_info, args.release_manager)
  File "/private/var/folders/y2/6t5bbk554wv5h6w_qlgpcpnm0000gr/T/pants-sandbox-CBBpeH/src/python/pants_release/start_release.py", line 95, in commit_and_pr
    pr = repo.create_pull(
  File "/Users/andreas.stenius/.cache/pants/named_caches/pex_root/venvs/s/21ffee03/venv/lib/python3.9/site-packages/github/Repository.py", line 1469, in create_pull
    return self.__create_pull_1(*args, **kwds)
  File "/Users/andreas.stenius/.cache/pants/named_caches/pex_root/venvs/s/21ffee03/venv/lib/python3.9/site-packages/github/Repository.py", line 1500, in __create_pull_1
    return self.__create_pull(
  File "/Users/andreas.stenius/.cache/pants/named_caches/pex_root/venvs/s/21ffee03/venv/lib/python3.9/site-packages/github/Repository.py", line 1513, in __create_pull
    headers, data = self._requester.requestJsonAndCheck(
  File "/Users/andreas.stenius/.cache/pants/named_caches/pex_root/venvs/s/21ffee03/venv/lib/python3.9/site-packages/github/Requester.py", line 455, in requestJsonAndCheck
    return self.__check(
  File "/Users/andreas.stenius/.cache/pants/named_caches/pex_root/venvs/s/21ffee03/venv/lib/python3.9/site-packages/github/Requester.py", line 500, in __check
    raise self.createException(status, responseHeaders, data)
github.GithubException.GithubException: 422 {"message": "Validation Failed", "errors": [{"resource": "PullRequest", "field": "head", "code": "invalid"}], "documentation_url": "<https://docs.github.com/rest/pulls/pulls#create-a-pull-request>"}
errno:1
opened the release prep PR manually..
b
This is why we need our release prep to be: • Push a tag 😂
👍 2
c
for <=2.17 do I follow the release process described in the docs on that branch? (so, no 
start_release.py
script fwict)?
b
Yeah
👍 1
c
ehm. the 
changelog.py
script does not seem to agree with the instructions..? Doc:
From the 
main
branch, run 
pants run build-support/bin/changelog.py -- --prior 2.9.0.dev0 --new 2.9.0.dev1
with the relevant versions.
but the file is in 
src/python/pants_release/changelog.py
and doesn’t seem to take more than a single tag as input arg.. 🤔
(looking at the 2.17.x branch)
I’ll pick this up on Sunday again..
b
Yeah you do that from the release branch. Will update the docs
👍 1
c
I got game-sniped this weekend, so will take care of releases in the coming day(s)..
some hiccups during the publish step for both 2.18 and 2.19 releases: https://github.com/pantsbuild/pants/actions/runs/6229202331/job/16907581355 https://github.com/pantsbuild/pants/actions/runs/6229007616/job/16907106204 🤞 that @bitter-ability-32190 can work some magic fixing that.. otherwise we’ll circle back, fix and redo.
b
Looks like protoc for both. CC @fast-nail-55400 and @broad-processor-92400
Fix was merged. I'll baby those releases tomorrow
🙏 1
2.19. has a missing token. Will PR and patch workflow
👀 1
I suspect 2.18.x will also run afoul
😢 1
github.GithubException.GithubException: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/users/users#get-the-authenticated-user"}
Boooo
OK looks like I'll be manually patching the releases later tonight
c
this means that these versions are not yet really ready for consumption, right. perhaps we should flag that in #announce?
b
I think we're just missing notes...
c
oh, ok. yea that’s fine I guess. did’nt actually try them yet (which I just made apparent 😅 )
b
As always, thank you @curved-television-6568 for minesweeping
💥 1
😅 1
👍 1
w
❤️
2 Views
Open in Slack
PreviousNext
Powered by