Can someone help me understand `pants-plugins/inte...
# developmentb
bitter-ability-32190
08/31/2023, 8:29 PMCan someone help me understand
pants-plugins/internal_plugins/test_lockfile_fixturessrc/python/pants/backend/codegen/avro/java/rules_integration_test.pyfrom internal_plugins.test_lockfile_fixtures.lockfile_fixturebitter-ability-32190
08/31/2023, 8:39 PMLooks like that file can just move to
pants.jvmf
fast-nail-55400
08/31/2023, 10:20 PMIf it moved to pants.jvm, would it be visible to users of the Pants wheels?
b
bitter-ability-32190
08/31/2023, 10:21 PMOnly if non-tests import it
f
fast-nail-55400
08/31/2023, 10:22 PMThat internal plugin code should not get published. And the code was separated out into that internal_plugins directory since it is a development stage repo-internal plugin.
fast-nail-55400
08/31/2023, 10:23 PMWhat are the boundaries that are being "broken"?
fast-nail-55400
08/31/2023, 10:25 PMI'm just wary of taking something which is currently separate and exposing it to a place where it might get published if someone imports something from the wrong place.
b
bitter-ability-32190
08/31/2023, 10:31 PMSince they're in the same resolve, i suspect that could already be the case. Also specifically it's just two dataclasses.
And I'm looking into putting the pants repo plugins in their own resolve. (Although that point might be moot)
bitter-ability-32190
09/01/2023, 11:39 AMAnd yeah, if someone was to import in Pants shipping code, nothing is stopping them. After adding the import to a JVM file:
Copy code
josh@cephandrius:~/work/pants$ pants paths --from=src/python/pants:pants-packaged --to=pants-plugins/internal_plugins/test_lockfile_fixtures/lockfile_fixt
ure.py
[
...
]