https://pantsbuild.org/ logo
Join Slack
Powered by
Hmm from `version.py`: <https://github.com/pantsbu...
# development
b
Hmm from `version.py`: https://github.com/pantsbuild/pants/blob/main/src/python/pants/version.py#L60
Copy code
# Do not remove/change this env var without coordinating with `pantsbuild/scie-pants` as it is
    # being used when bootstrapping Pants with a released version.
    os.environ.get(_PANTS_VERSION_OVERRIDE)
Is this true? I get no hits in 
scie-pants
codebase for 
_PANTS_VERSION_OVERRIDE
, 
PANTS_VERSION_OVERRIDE
or even no relevant ones for 
OVERRIDE
... Anyone got a clue?
c
typo 🙈
b
So is it really necessary if it's broken today and none of us notticed? 😂
c
good question
something feels fishy for sure
b
🐟
c
I can throw a 🎣 tonight to revisit what I did back then…
Ah, this is the use case it supports, so guess no one has tried running another version of pants from the pants repo then: https://github.com/pantsbuild/scie-pants/pull/100
b
Oof
c
because this should work: 
PANTS_VERSION=2.15.0 pants -V
also in the pants repo.
but that is broken, due to the typo
b
So, to get this straight, you want the current copy of the code, but an older version of the Pants binary?
c
which you may be trying to do soon.. 😂
yes
Copy code
pants.base.exceptions.BuildConfigurationError: Version mismatch: Requested version was 2.16.0, our version is 2.18.0a0.
b
Full circle, huh?
c
there may be compatibility issues then, as it’ll use the 
pants.toml
from the source repo, so some new backends may cause issues if it’s not present in the older version and stuff like that…
but if you go only one version back, should be mostly fine 😅
b
Oh right, but my plan was to edit 
pants.toml
to remove the delegation shh
c
hehe… no need then, maybe. if this works.
b
Honestly, I'ts probably worth the pain if you wanna do weird shit
But thats me
c
I fixed the typo real quick in pants repo and got further (but not the whole way due to config issues)
I was going for backwards compat with using the 
./pants
bootstrap scripts..
b
I mean, I won't block you trying to get this working, lol
c
well, step one is to fix the mis-align with how this is named 😛
I can put up a PR tonight, likely in 
scie-pants
as that’s where I got this backwards
as you have other changes going into scie-pants as well, would be nice to get both into the same version bump?
b
Yeah I'll have another one for firewalls as well
👍 1
4 Views
Open in Slack
PreviousNext
Powered by